combine foreach with linq

Question

How to change the following code to one LINQ query :

var items = (from s in db.WfRADocStates.Include(x => x.WfStateStatu)
                                       .Include(xx => xx.WfState)
                                       .Include(xxx => xxx.WfState.Dept)
                                       .Include(d => d.RADoc)
             where s.RADocID == docID
                && !s.isHistory
                && s.StatusID == 1
                && s.WfStateStatu.isToNotify
             select s).ToList();

foreach (var item in items)
{
    EmailHelper.notify(item);
}

look at [this question](http://stackoverflow.com/questions/200574/linq-equivalent-of-foreach-for-ienumerablet) and note that `LINQ` is should be used for `Q`uerying — Jonesopolis, Feb 26 '14 at 04:48
@Jonesy `ForEach` technically isn't LINQ. It's a method on `List` not `IEnumerable` it just happens take a delegate as it's argument so it looks the same as LINQ's query syntax. Really, the `Where` is LINQ, the `Select` does nothing and the `ForEach` is just a method in `List` that is called on the results of the LINQ query. — evanmcdonnal, Feb 26 '14 at 04:50
Your code is perfectly sensible as it's written. Don't change it. A query produces a *query*; a loop produces a *side effect*. Don't make a *query* that produces a *side effect*; that's not its job. A query's job is to answer a question, not do a task. A loop's job is to do a task. — Eric Lippert, Feb 26 '14 at 05:47

score 2 · Accepted Answer · answered Feb 26 '14 at 04:46

2

Use .ForEach in the LINQ :

(from s in db.WfRADocStates.Include(x=>x.WfStateStatu).Include(xx=>xx.WfState).Include(xxx=>xxx.WfState.Dept).Include(d=>d.RADoc)
         where
            s.RADocID == docID &&
            !s.isHistory &&
            s.StatusID == 1 &&
            s.WfStateStatu.isToNotifyCNH
         select s).ToList().ForEach(
                s => EmailHelper.notify(s)
         );

answered Feb 26 '14 at 04:46

Maddy

300
1
8

1

`ForEach` is not a `LINQ` extension method.It's defined in `List` – Selman Genç Feb 26 '14 at 04:54

score 1 · Answer 2 · answered Feb 26 '14 at 04:48

1

Give this a try (excluding all this include nonsense);

Collection.Where(s => s.RadocID == docID && ...).ToList().ForEach(s => EmailHelper.notify(s));

answered Feb 26 '14 at 04:48

evanmcdonnal

46,131
16
104
115

combine foreach with linq

2 Answers2

Linked