PHP Script doesn't work on my form

Question

I have a HTML form, and a php script for saving the elements into a .txt file. Here's my form:

<div class="col-md-6">
    <h2>Send us a message</h2>
    <form id="contact-form" action="myscript.php" method="POST">
        <div class="row">
            <div class="col-md-6">
                <input name="name" id="name" type="text" placeholder="Name" />
                <input name="email" id="email" type="text" placeholder="E-Mail" />
                <input name="subject" id="subject" type="text" placeholder="Subject" />
            </div>

            <div class="col-md-6">
                <textarea name="comment" id="comment" placeholder="Message"></textarea>
                <input type="submit" id="submit_contact" value="Send message" />
                <div id="msg" class="message"></div>
            </div>
        </div>
    </form>                     
</div>

And my php script:

<?php
if(isset($_POST['name']) && isset($_POST['email']) && isset($_POST['subject']) && isset($_POST['comment'])) {
    $data ='Name : ' . $_POST['name'] . "\n" . 'E-Mail : ' . $_POST['email'] . "\n" . 'Website : ' . $_POST['subject'] . "\n" . 'Comment : ' . $_POST['comment'] . "\n" . '----------------------------------------------------------------' . "\n";
    $ret = file_put_contents('comments.txt', $data, FILE_APPEND);
    if($ret === false) {
        echo "<script>alert('Failure!');</script>";
    }
    else {
        echo "<script>alert('Success!');</script>";
    }
    }
    else {
      echo "<script>alert('Fill in The Form Please !');</script>";
    }

When I fill the form and press submit, nothing happens actually. But when I remove the DIV tags it works.

Here are my full codes: My HTML code and my CSS code

So it is not about the PHP script but your HTML or maybe some JS? — putvande, Feb 27 '14 at 18:48
@relentless , i mean all of them . i removed all of them and tried again and it worked fine. — Mahdi Abdi, Feb 27 '14 at 18:50
Do you have more HTML around it that you are not showing? Sounds a bit odd that a few HTML tags stop your form from submitting. — putvande, Feb 27 '14 at 18:51
@putvande , yes i think it's not about php , but i don't know which part has problem . — Mahdi Abdi, Feb 27 '14 at 18:51
@dg988 , that's this code . i just removed the
tags. that's it. — Mahdi Abdi, Feb 27 '14 at 18:53
Well, with all due respect, don't trust yourself. That's why you're asking us. — bearfriend, Feb 27 '14 at 18:54
Your CSS file have very important errors on } . so some browsers may delete form inputs. You can del CSS file or change internet browser to test it. — Huseyin, Feb 27 '14 at 19:01
if thats your whole php file, you should get an exception because you're missing that ending bracket of your if clause. — malifa, Feb 27 '14 at 19:01
Does it submit when you tab to the submit button and hit enter? Does the submit button visually change `onmousedown`? — bearfriend, Feb 27 '14 at 19:02
@dg988 The Valid Form that does work : http://pastebin.ubuntu.com/7006617/ there is some js files , do you need to see them? — Mahdi Abdi, Feb 27 '14 at 19:04
You've got some funky css going on. My best guess is that something is z-indexed on top of your submit button. Can you say whether tabbing to the submit button and hitting enter works? — bearfriend, Feb 27 '14 at 19:07
If you focus on (click so the outside is highlighted and you can type into) one of the text boxes (inputs), and then press the "tab" key on your keyboard, it should move to the next text box. if you do this again, it will eventually move to the "submit" button. Once there, press the "enter" key. Does it work? — bearfriend, Feb 27 '14 at 19:18
@dg988 he has a submit button, it should submit if he presses enter while any input control has focus. — Snowburnt, Feb 27 '14 at 19:18
@Snowburnt He has multiple inputs. This prevents "enter" submitting. — bearfriend, Feb 27 '14 at 19:19
@Snowburnt No, sorry. I think you're right. The submit should negate that, right? — bearfriend, Feb 27 '14 at 19:20
@dg988 if it's in a form tag, pressing enter will perform the submit function — Snowburnt, Feb 27 '14 at 21:13
@Snowburnt ...unless there multiple inputs, and no submit button. Got it. — bearfriend, Feb 27 '14 at 21:27
@dg988 http://stackoverflow.com/questions/925334/how-is-the-default-submit-button-on-an-html-form-determined the first answer here pretty much clears it up. Multiple inputs are irrelevant, but the function of the enter key within a form in a nontextarea is determined by the browser, there's no actual spec for it. — Snowburnt, Feb 28 '14 at 15:12
@Snowburnt Without a submit button, multiple inputs are indeed relevant. One input + enter will submit. Two inputs + enter will do nothing. Any number of inputs + submit button + enter will submit. — bearfriend, Feb 28 '14 at 15:40

Ryan Vincent · Accepted Answer · 2014-03-02T14:35:12.190

Your code and the HTML as posted. Included your css.

You have an extra brace in the script.

This code shows the form and creates the 'comments.txt' file.

Added test to ensure all the fields are entered

PHP 5.3.18 on windows XP.

<?php

if (isset($_POST['myscript'])) { // the form was submitted...


    if(   isset($_POST['name'])    && !empty($_POST['name'])
       && isset($_POST['email'])   && !empty($_POST['email'])
       && isset($_POST['subject']) && !empty($_POST['subject'])
       && isset($_POST['comment']) && !empty($_POST['comment'])) {

        $data ='Name : ' . $_POST['name'] . "\n" . 'E-Mail : ' . $_POST['email'] . "\n" . 'Website : '
                . $_POST['subject'] . "\n" . 'Comment : ' . $_POST['comment'] . "\n"
                . '----------------------------------------------------------------' . "\n";
        $ret = file_put_contents('comments.txt', $data, FILE_APPEND);
        if($ret === false) {
            echo "<script>alert('Failure!');</script>";
        }
        else {
            echo "<script>alert('Success!');</script>";
        }
    }
    else {
      echo "<script>alert('Fill in The Form Please !');</script>";
    }
}
?>

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
    <title>Q22077564</title>
    <LINK REL=StyleSheet HREF="Q22077564.css" TYPE="text/css" MEDIA=screen>
  </head>

<body>
<div class="col-md-6">
    <h2>Send us a message</h2>
    <form id="contact-form" action="myscript.php" method="POST">
      <!-- add hidden field so that we know the form came in! -->
      <input type="hidden" name="myscript"  value="myscript" />;
      <div class="row">
            <div class="col-md-6">
                <input name="name" id="name" type="text" placeholder="Name" />
                <input name="email" id="email" type="text" placeholder="E-Mail" />
                <input name="subject" id="subject" type="text" placeholder="Subject" />
            </div>

            <div class="col-md-6">
                <textarea name="comment" id="comment" placeholder="Message"></textarea>
                <input type="submit" id="submit_contact" value="Send message" />
                <div id="msg" class="message"></div>
            </div>
        </div>
    </form>
</div>
</body>
</html>

Thanks a lot . it works but when i run it , an alert shows "success" . and it mustn't show that at the first place. what should i do ? — Mahdi Abdi, Mar 02 '14 at 14:01
@ShaPesar `if(isset($_POST['submit'])) { // form has been posted } else { // diplay form, no past has been made yet }` — BlueCacti, Mar 02 '14 at 14:08
added a hidden field to detect the form being submitted. Used your CSS. The code appends entries into the comment.txt file. — Ryan Vincent, Mar 02 '14 at 14:19

score 0 · Answer 2 · answered Mar 02 '14 at 13:47

<?php
if(isset($_POST['name']) && isset($_POST['email']) && isset($_POST['subject']) && isset($_POST['comment'])) {
$data ='Name : ' . $_POST['name'] . "\n" . 'E-Mail : ' . $_POST['email'] . "\n" . 'Website : ' . $_POST['subject'] . "\n" . 'Comment : ' . $_POST['comment'] . "\n" . '----------------------------------------------------------------' . "\n";
$ret = file_put_contents('comments.txt', $data, FILE_APPEND);
if($ret === false) {
    echo "<script>alert('Failure!');</script>";
}
else {
    echo "<script>alert('Success!');</script>";
}
}
else {
  echo "<script>alert('Fill in The Form Please !');</script>";
} **}**//not your answer but you should remove this one right

PHP Script doesn't work on my form

2 Answers2