Rails 4 find or create by method doesn't work

Question

I have a one to many association between jobs and companies and it works fine. In the job form view I have text_field for the company name with an autocomplete feature. The autocomplete works fine but the find_or_create_by don't create a new company if I put a company name that doesn't exist in the autocomplete list.

  def company_name
    company.try(:name)
  end

  def company_name=(name)
    @company = Company.find_or_create_by(name: name)
  end

If i create a job and put a new company that did not exit in the companies list the new company will not be created — Loenvpy, Mar 20 '14 at 14:59

score 112 · Accepted Answer · edited May 23 '17 at 11:47

112

Please take a look at this answer.

What used to be

@company = Company.find_or_create_by_name(name)

in Rails 4 is now

@company = Company.find_or_create_by(name: name)

Another way to do this in Rails 4 would be:

@company = Company.where(name: name).first_or_create

edited May 23 '17 at 11:47

Community

1
1

answered Jul 15 '14 at 17:11

eronisko

1,862
1
15
14

Kalpesh Fulpagare · Answer 2 · 2016-01-31T10:34:29.150

26

Company.find_or_create_by(name: name)

It should work out of the box. Only thing that can prevent it from creating record is validation errors.

Try this in rails console to check if its working or not. And check the validation errors as well.

name = "YOUR TEXT FOR NAME ATTRIBUTE"
c = Company.find_or_create_by(name: name)
puts c.errors.full_messages

edited Jan 31 '16 at 10:34

answered Mar 27 '14 at 09:18

Kalpesh Fulpagare

1,309
10
18

This is also a vlid answer – Jerome Sep 28 '15 at 16:28
This is a good answer. I had validation errors after find_or_create_by that I missed and was wondering about. I added save! and found the validation errors. thanks! – rajat banerjee Jan 19 '17 at 05:26

score 0 · Answer 3 · edited May 26 '15 at 23:29

0

This method is deprecated in rails 4.

Rails4 release message:

Deprecated the old-style hash based finder API. This means that methods which previously accepted "finder options" no longer do.

It is deprecated method, but it should work. Maybe, Rails is not supporting it now.

You can get more info click here and check 11.2 Deprecations.

edited May 26 '15 at 23:29

Rick Smith

9,031
15
81
85

answered Mar 27 '14 at 09:35

uma

2,932
26
20

12

Its the `find_or_create_by_name( name )` style that is deprecated. `find_or_create_by( name: name )` is still fine and the recommended way of doing it, as per the documentation you link to... – Jonas Schubert Erlandsson Dec 28 '14 at 19:35

Rails 4 find or create by method doesn't work

3 Answers3

Linked