Why doesn't my string comparison with == work?

Question

I have this, in my onPostExecute :

    String test = currentActivity.getClass().getSimpleName();
    if(test == "SplashScreen"){
        Log.e("OK",test);

    } else {
        Log.e("OK",test);

    }

The problem is, the value of test is "SplashScreen" (that we can see with the log), but the code never goes in the if, only in the else.

Why does this happen?

have a look here http://stackoverflow.com/questions/995918/java-comparison-with-of-two-strings-is-false — Piotr Zurkowski, Apr 01 '14 at 21:41

score 3 · Answer 1 · answered Apr 01 '14 at 21:45

As the others had already said you can not use the == operator on strings. The reason for this is that strings are objects and not primitive datatypes. With that said the == operator will check if the two strings has the same memory point in the memory if I'm not mistaken.

score 2 · Answer 2 · answered Apr 01 '14 at 21:41

2

use equals to compare strings:

 if(test.equals("SplashScreen"){ 
  Log.e("OK",test);

 } else {
    Log.e("OK",test);

}

answered Apr 01 '14 at 21:41

Zied R.

4,964
2
36
67

score 2 · Answer 3 · answered Apr 01 '14 at 21:41

2

You can't use == on strings. You should use:

"SplashScreen".equals(test)

Test might be null, it is better to call equals() on "SplashScreen" since you know that it is no null.

answered Apr 01 '14 at 21:41

l-l

3,804
6
36
42

yes, of course... i forgot it.... i need to stop Php :D thx – deveLost Apr 01 '14 at 21:42
@Myste - and you need to start searching for answers before you ask Questions. This one has been asked thousands of times before. – Stephen C Apr 01 '14 at 21:46

score 0 · Answer 4 · answered Apr 01 '14 at 21:42

0

Don't compare string with == use .equals()

String test = currentActivity.getClass().getSimpleName();
if(test.equals("SplashScreen")){
    Log.e("OK",test);

} else {
    Log.e("OK",test);

}

answered Apr 01 '14 at 21:42

Anthony Raymond

7,434
6
42
59

score 0 · Answer 5 · answered Apr 01 '14 at 21:43

0

It's better to use equalsIgnoreCase(String string).

 String test = currentActivity.getClass().getSimpleName();
if(test.equalsIgnoreCase("SplashScreen")){
    Log.e("OK",test);

} else {
    Log.e("OK",test);

}

answered Apr 01 '14 at 21:43

loumaros

433
3
7

Why doesn't my string comparison with == work?

5 Answers5