loging php page not redirecting

Question

I'm working on a login page by user level to separate the admin and user. but it didnt seems to work. it doesnt redirect and leave a blank page. I've tried remove the javascript part, but it doesnt change anything either.

index.php

<form class="login" action="login.php" method="post">
Username:<input type="text" name="username" id="username"/>
Password:<input type="password" name="password" id="password"/>
<input type="submit" value="login"/>
</form>

login.php

<?php 
    session_start();
    include('config.php');

    if(isset($_POST['submit'])) {

        $username = $_POST['username'];
        $password = $_POST['password'];

            $username = mysql_real_escape_string($username);    
            $password = mysql_real_escape_string($password);

            $sql = mysql_query("SELECT * FROM admin WHERE username='$username' AND password='$password'");
            $result = mysql_fetch_array($sql);

            $username=$result['username'];
    $adminID=$result['adminID'];
    $userLevel=$result['UserLevel'];

    $_SESSION['adminID']=$adminID;
    $_SESSION['userLevel']=$userLevel;
    $_SESSION['username']=$username;
    $_SESSION['password']=$password;

    if($userLevel == '1')
    {
     $sql = "UPDATE admin SET status = 'AKTIF' where username = '$username' ";
     $result = mysql_query($sql) or die('Cannot UPDATE.'.mysql_error());
    ?>

    <script type="text/javascript">
        alert("Welcome <?php echo "$username" ?> to Admin page! ");
    </script>

    <?php
        header('Location:admin.php');
        exit();
    }

    elseif($userLevel == '0')
    {
    $sql = "UPDATE admin SET status = 'AKTIF' where username = '$username' ";
    $result = mysql_query($sql) or die('Cannot UPDATE.'.mysql_error());
    ?>

    <script type="text/javascript">
        alert("Welcome <?php echo "$username" ?> to User page! ");
    </script>

    <?php
        header('Location: user.php');
        exit();
    }

    else
    {   
    ?>
       <script type="text/javascript">
        alert("Invalid Username or Password! ");
        //window.location.href = "index.php";
    </script>

    <?php
    }
}

?>

http://stackoverflow.com/questions/8130990/how-to-redirect-to-the-same-page-in-php <-- read this — Black Sheep, Apr 07 '14 at 01:07
sorry.. read this --> http://stackoverflow.com/questions/768431/how-to-make-a-redirect-in-php <-- thats what you need — Black Sheep, Apr 07 '14 at 01:12
@aldanux ah I forgot to mention, but I've tried using `header` too. but no luck as well. — Syaa, Apr 07 '14 at 01:18
Don't mess up page logic and representation, it looks horrible and is breeding ground for mistakes and errors. Use MySQL PDO and bind values to queries, to make it more secure. Use session based "flash messages", do not create meta tags like that: if login is successful, store new message in session and redirect user to login sucessfull page and in HTML, output all session messages and clear them. Plaintext passwords? Use crypt()! And why store password in session? You need only user ID. — Deele, Apr 07 '14 at 01:19
@Deele: No, not [`crypt`](https://www.php.net/crypt)! [`password_hash`](https://www.php.net/password_hash) (possibly using [a shim](https://github.com/ircmaxell/password_compat) if your version of PHP doesn't have it natively)! — icktoofay, Apr 07 '14 at 01:40
your code is not dynamic because javascript is client language and php is server language. I m not sure this code is it having some problem but the way you use I think have problem when you write php code inside javascript. Try to avoid this kind of method you using and try to put javascript inside php code rather than php code inside javascript. — user3454436, Apr 07 '14 at 02:37

kimbarcelona · Accepted Answer · 2014-04-07T01:58:32.213

1

Use PHP Header:

for userLevel1:
header("Location: admin.php");

for userLevel2:
header("Location: user.php");

Name in your submit so it will enter your PHP code block:

<input type="submit" name="submit" value="login"/>

edited Apr 07 '14 at 01:58

answered Apr 07 '14 at 01:18

kimbarcelona

1,136
2
8
19

It's redirecting on my localhost – kimbarcelona Apr 07 '14 at 01:42
how did you set it up? – Syaa Apr 07 '14 at 01:52
Just put name in your submit – kimbarcelona Apr 07 '14 at 01:57
i did what you suggest. and i also change `if(isset($_POST['submit']))` to `if(isset($_POST['login']))` – Syaa Apr 07 '14 at 02:09
and now it gives the error `Undefined index: userLevel in C:\wamp\www\FORM\login.php on line 22` which is `$userLevel=$result['userLevel'];` – Syaa Apr 07 '14 at 02:11
1

is the name of the field on your table userLevel? – kimbarcelona Apr 07 '14 at 02:16
ah indeed I forgot to capitalize the word. its working, the welcome alert box is showing. but it doesnt redirect. when I use `header` it still stay at login.php. but when i use `window.location.href = "admin.php";` it went back to index.php . i'm confused. – Syaa Apr 07 '14 at 02:27
Please use header('Location: ') not window.location.href because it's not a php script. You might also need to add after each alert. – kimbarcelona Apr 07 '14 at 02:29
yea but when I user `header` it doesnt redirect. see my update – Syaa Apr 07 '14 at 02:37
header("Location: admin.php"); not header("admin.php"); – kimbarcelona Apr 07 '14 at 02:52
of course! how silly. the code works! but....... now the alert box wont show. it redirect to the page without the alert box. ah. :( – Syaa Apr 07 '14 at 03:04
Why don't you put the alert on the page that it will be redirected to. It's better that way. :) – kimbarcelona Apr 07 '14 at 03:06
put alert on the page? – Syaa Apr 07 '14 at 03:12
Yeah example in the admin.php, as it redirected in there, put an alert as it load. – kimbarcelona Apr 07 '14 at 04:58

score 0 · Answer 2 · answered Apr 07 '14 at 02:43

0

try the following code and replace into your code. see whether can work or not. you try on the first if condition first and see on the result. if cannot work tell me what problem you face.

<?php
    if($userLevel == '1')
                 $sql = "UPDATE admin SET status = 'AKTIF' where username = '$username' ";
                 $result = mysql_query($sql) or die('Cannot UPDATE.'.mysql_error());
    ?>
    <script>
                var a = alert("Welcome <?php echo "$username" ?> to Admin page! ");
    if (a === true){
    window.location.href="admin.php";
    }
    else{
    window.location.href="admin.php";
    }
</script>
    <?php
                }

answered Apr 07 '14 at 02:43

user3454436

231
1
4
15

just replace the code like what i did. I forget to put and I have update my code. just copy 1 time and replace it to your code – user3454436 Apr 07 '14 at 02:47
This is poor coding standard. Why use client side code if it can be done with server-side – kimbarcelona Apr 07 '14 at 02:55
do you have any good example to provide. forgive my stupidness code but i just want to help him. please help him to work on it. thanks. – user3454436 Apr 07 '14 at 02:58

loging php page not redirecting

2 Answers2