NullPointerException when I try to use a custom Fragment

Question

I'm trying to use a Fragment in an Activity, I have used this code for the Fragment class

public class MyFragment extends Fragment {
    private TextView txtT1, txtT2;

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {
        // Inflate the layout for this fragment
        View view = inflater.inflate(R.layout.my_fragment, container, false);

        txtT1 = (TextView) getView().findViewById(R.id.txtT1);
        txtT2 = (TextView) getView().findViewById(R.id.txtT2);

        return view;
    }
}

The NullPointerException log show the error exactly on these lines

        txtT1 = (TextView) getView().findViewById(R.id.txtT1);
        txtT2 = (TextView) getView().findViewById(R.id.txtT2);

the xml fragment named my_fragment is this

<?xml version="1.0" encoding="utf-8"?>

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" android:orientation="vertical"
android:layout_width="match_parent" android:layout_height="match_parent">


    <LinearLayout
        android:layout_width="380dp"
        android:layout_height="100dp"
        android:layout_alignParentBottom="true"
        android:background="@drawable/background"
        android:layout_centerHorizontal="true"
        android:orientation="vertical"
        android:id="@+id/BoxFragment"
        android:layout_margin="5dp"
        android:layout_gravity="center_horizontal">

        <TextView
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:textAppearance="?android:attr/textAppearanceSmall"
            android:text="@string/title"
            android:gravity="center_horizontal"
            android:id="@+id/txtTitle"
            android:textSize="13sp"/>

        <ScrollView
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:id="@+id/scrollView"
            android:layout_gravity="center_horizontal"
            android:fillViewport="true"
            android:paddingLeft="6dp"
            android:paddingRight="6dp"
            >

            <HorizontalScrollView
                android:layout_width="match_parent"
                android:layout_height="match_parent"
                android:id="@+id/horizontalScrollView"
                android:fillViewport="true">

                <LinearLayout
                    android:orientation="vertical"
                    android:layout_width="fill_parent"
                    android:layout_height="fill_parent"
                    android:gravity="center">

                    <LinearLayout
                        android:orientation="horizontal"
                        android:layout_width="wrap_content"
                        android:layout_height="wrap_content"
                        android:layout_gravity="center_horizontal"
                        android:id="@+id/summaryRow1">

                        <TextView
                            android:layout_width="wrap_content"
                            android:layout_height="wrap_content"
                            android:textAppearance="?android:attr/textAppearanceSmall"
                            android:text="@string/sample1"
                            android:id="@+id/titlT1"
                            android:textSize="13sp"/>

                        <TextView
                            android:layout_width="match_parent"
                            android:layout_height="wrap_content"
                            android:textAppearance="?android:attr/textAppearanceSmall"
                            android:text="..."
                            android:id="@+id/txtT1"
                            android:gravity="center_horizontal"
                            android:textSize="12sp"
                            android:layout_marginLeft="3dp"/>

                        <TextView
                            android:layout_width="wrap_content"
                            android:layout_height="wrap_content"
                            android:textAppearance="?android:attr/textAppearanceSmall"
                            android:text="@string/sample2"
                            android:id="@+id/titlT2"
                            android:textSize="13sp"
                            android:layout_marginLeft="5dp"/>

                        <TextView
                            android:layout_width="wrap_content"
                            android:layout_height="wrap_content"
                            android:textAppearance="?android:attr/textAppearanceSmall"
                            android:text="..."
                            android:id="@+id/txtT2"
                            android:textSize="12sp"
                            android:layout_marginLeft="3dp"/>

                    </LinearLayout>

                </LinearLayout>
            </HorizontalScrollView>
        </ScrollView>

    </LinearLayout>


</LinearLayout>

you need to use view.findView, you don't have a getView() until the return of this method — sherpya, Apr 24 '14 at 21:00
possible duplicate of [getView returning null when fragment has been created from an activity](http://stackoverflow.com/questions/9488595/getview-returning-null-when-fragment-has-been-created-from-an-activity) — Selvin, Apr 24 '14 at 21:09

Ahmad · Accepted Answer · 2014-04-24T21:06:45.993

2

getView() returns the View, that was returned in onCreateView() and therefore it should be null when you call getView() in onCreateView().

Try changing this line

    View view = inflater.inflate(R.layout.my_fragment, container, false);

    txtT1 = (TextView) getView().findViewById(R.id.txtT1);
    txtT2 = (TextView) getView().findViewById(R.id.txtT2);

to

    View view = inflater.inflate(R.layout.my_fragment, container, false);

    txtT1 = (TextView) view.findViewById(R.id.txtT1);
    txtT2 = (TextView) view.findViewById(R.id.txtT2);

edited Apr 24 '14 at 21:06

answered Apr 24 '14 at 21:01

Ahmad

69,608
17
111
137

Thanks this is the cause of the error. I will accept your answer after the countdown – AndreaF Apr 24 '14 at 21:03

NullPointerException when I try to use a custom Fragment

1 Answers1