0

i got this code : 

Object.defineProperty(Array.prototype, "remove", {
    enumerable: false,
    value: function (item) {
        var removeCounter = 0;

        for (var index = 0; index < this.length; index++) {
            if (this[index] === item) {
                this.splice(index, 1);
                removeCounter++;
                index--;
            }
        }

        return removeCounter;
    }
});

And i try to remove from array specific elements with this code line :

var itemsRemoved = finalArray.remove(getBack);

But if i do console.log() it return 0 elements removed while my variable getBack is equal with 0 or other number and in array getBack value exists.

user3459377
  • 241
  • 1
  • 2
  • 9

2 Answers2

0

Use item.indexOf(this[index]) instead of this[index] === item.

Why? item is an Array and not a single Value:

Object.defineProperty(Array.prototype, "remove", {
    enumerable: false,
    value: function (item) {
        var removeCounter = 0;

        for (var index = 0; index < this.length; index++) {
            console.log(this[index], item);
            if (item.indexOf(this[index]) > -1) {
                this.splice(index, 1);
                removeCounter++;
                index--;
            }
        }

        return removeCounter;
    }
});
Adrian Preuss
  • 3,228
  • 1
  • 23
  • 43
0

See this thread about object comparison in js

A quick way to achieve it :

Object.defineProperty(Array.prototype, "remove", {
    enumerable: false,
    value: function (item) {
        var removeCounter = 0;

        for (var index = 0; index < this.length; index++) {
            if (JSON.stringify(this[index]) === JSON.stringify(item)) {
                this.splice(index, 1);
                removeCounter++;
                index--;
            }
        }

        return removeCounter;
    }
});
Community
  • 1
  • 1
dpellier
  • 1,029
  • 11
  • 9