Why are default parameters being used?

Question

The following code gives me default values, even if I try several values. I can't find a logical mistake :(

I must have done something wrong with the constructors, but I have no clue why they don't work as intended.

    class cGeoPos {
    private:
        double lang = 8.7;
        double breit = 52.5;
    public:
        cGeoPos(){
        }
        cGeoPos(double lang_in, double breit_in){
            lang = lang_in;
            breit = breit_in;
        }
        void setGeoPos(double lang_in, double breit_in){
            lang = lang_in;
            breit = breit_in;
        }
        void printGeoPos(){
            cout << lang << "\t" << breit << endl;
        }
    };

    class cBaum {
    private:
        string art = "-";
        double hoch = 0;
        cGeoPos posi;
    public:
        cBaum(){
            art = "-";
            hoch = 0;
            posi.setGeoPos(0, 0);
        }
        cBaum(string art_in, double hoch_in, double lang_in, double breit_in)
        {
            art = art_in;
            hoch = hoch_in;
            cGeoPos;
            posi.setGeoPos(lang_in, breit_in);
        }
        int eingabe(){
            string art_in;
            double hoch_in, lang_in, breit_in;
            cout << endl << "Bitte Baumart eingeben: ";
            cin >> art_in;
            cout << endl << "Bitte Hoehe eingeben: ";
            cin >> hoch_in;
            cout << endl << "Bitte geografische Laenge eingeben: ";
            cin >> lang_in;
            cout << endl << "Bitte geografische Breite eingeben: ";
            cin >> breit_in;
            cBaum(art_in, hoch_in, lang_in, breit_in);
            if (art_in == "-") {
                return 0;
            }
            else {
                return 1;
            }
        }


    int main()
    {
        int i = 0;

        cBaum wald[1000];
        while (i < 1000) {
            if (wald[i].eingabe() == 0) {
                return 1;
            }
            i++;
        }

        return 0;
    }

Answer 1

Did you mean to assign?

        *this = cBaum(art_in, hoch_in, lang_in, breit_in);

The more usual approach here would be to say

this->art = art_in; 
this->hoch = hoch_in;

etc.

You'd also want to add input validation.

Update Here's typical C++ idioms to do the same Live On Coliru

#include <iostream>
#include <string>
#include <vector>

class cGeoPos {
    private:
        double lang;
        double breit;
    public:
        cGeoPos(double lang_in = 8.7, double breit_in = 52.5) 
            : lang(lang_in), breit(breit_in)
        { }

        friend std::ostream& operator<<(std::ostream& os, cGeoPos const& posi) {
            return os << "(" << posi.lang << ", " << posi.breit << ")";
        }

        friend std::istream& operator>>(std::istream& is, cGeoPos& posi) {
            return is >> posi.lang >> posi.breit;
        }
};

class cBaum {
    private:
        std::string art;
        double hoch;
        cGeoPos posi;
    public:
        cBaum(std::string art = "-", double hoch = 0, double lang = 0, double breit = 0)
            : art(art), hoch(hoch), posi(lang, breit)
        { }

        bool valid() const { return art != "-"; }

        friend std::ostream& operator<<(std::ostream& os, cBaum const& baum) {
            return os << "[ '" << baum.art << "', Hőhe:" << baum.hoch << ", posi:" << baum.posi << " ]";
        }

        friend std::istream& operator>>(std::istream& is, cBaum& baum) {
            if (is >> baum.art && baum.art != "-")
                return is >> baum.hoch >> baum.posi;
            else
                return is;
        }
};


int main()
{
    std::vector<cBaum> wald;

    do {
        std::cout << "Bitte (Art, Hőhe, G. Länge, G. Breite) angeben: ";

        cBaum baum;
        if (std::cin >> baum)
        {
            if (!baum.valid()) // "-" entered
                break;
            wald.push_back(baum);
        } else
        {
            if (std::cin.eof())
                break;
            std::cout << "Ungűltiger Eintrag\n";
            std::cin.clear();
            std::cin.ignore(1024, '\n');
        }
    } while (true);

    for (auto& baum : wald)
        std::cout << baum << std::endl;
}

Output

[ 'Eich', Hőhe:1, posi:(4678.3, 324.89) ]
[ 'Esp', Hőhe:89, posi:(-468.3, 3e+09) ]
[ 'Palm', Hőhe:5, posi:(4, 4) ]

Answer 2

You probably expected that your code

cBaum(art_in, hoch_in, lang_in, breit_in);

would call the constructor. This doesn't work that way. To have a constructor call another constructor, you have to use dedicated syntax, which is not applicable in your example, so just accept that you cannot call a constructor.

Use an initialization function instead:

    initialize(string art_in, double hoch_in, double lang_in, double breit_in)
    {
        art = art_in;
        hoch = hoch_in;
        cGeoPos;
        posi.setGeoPos(lang_in, breit_in);
    }

Then, use it instead of the constructor:

initialize(art_in, hoch_in, lang_in, breit_in);

To avoid code duplication, change also the other constructor to call this function:

    cBaum(string art_in, double hoch_in, double lang_in, double breit_in)
    {
        initialize(art_in, hoch_in, lang_in, breit_in);
    }