Invalid IP Address android

Question

I am trying a sample to insert data from my data base to the server. But iam getting an Exception Invalid IP address. My IP is a global IP and can be accessed from any where

public class MainActivity extends Activity {

    String name;
    String id;
    InputStream is=null;
    String result=null;
    String line=null;
    int code;

    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        final EditText e_id=(EditText) findViewById(R.id.editText1);
        final EditText e_name=(EditText) findViewById(R.id.editText2);
        Button insert=(Button) findViewById(R.id.button1);

        insert.setOnClickListener(new View.OnClickListener() {

        @Override
        public void onClick(View v) {

            id = e_id.getText().toString();
            name = e_name.getText().toString();

            insert();
        }
    });
    }

    public void insert() {
        ArrayList<NameValuePair> nameValuePairs = new ArrayList<NameValuePair>();

        nameValuePairs.add(new BasicNameValuePair("id",id));
        nameValuePairs.add(new BasicNameValuePair("name",name));

        try {
            HttpClient httpclient = new DefaultHttpClient();
            HttpPost httppost = new HttpPost("http://****/insert.php");
            httppost.setEntity(new UrlEncodedFormEntity(nameValuePairs));
            HttpResponse response = httpclient.execute(httppost); 
            HttpEntity entity = response.getEntity();
            is = entity.getContent();
            Log.e("pass 1", "connection success ");
        } catch(Exception e) {
            Log.e("Fail 1", e.toString());
            Toast.makeText(getApplicationContext(), "Invalid IP Address",
            Toast.LENGTH_LONG).show();
        }     

        try {
            BufferedReader reader = new BufferedReader
                    (new InputStreamReader(is,"iso-8859-1"),8);
            StringBuilder sb = new StringBuilder();
            while ((line = reader.readLine()) != null) {
                sb.append(line + "\n");
            }
            is.close();
            result = sb.toString();
            Log.e("pass 2", "connection success ");
        } catch(Exception e) {
            Log.e("Fail 2", e.toString());
        }     

        try {
            JSONObject json_data = new JSONObject(result);
            code=(json_data.getInt("code"));

            if(code==1) {
                Toast.makeText(getBaseContext(), "Inserted Successfully",
                Toast.LENGTH_SHORT).show();
            } else {
                Toast.makeText(getBaseContext(), "Sorry, Try Again",
                Toast.LENGTH_LONG).show();
            }
        } catch(Exception e) {
            Log.e("Fail 3", e.toString());
        }
    }
}

I am new to this. For security reasons I cant put my IP. Please help me.

replace Log.e("Fail 1", e.toString()); at to e.printStackrtrace(), and get what you see on logcat, post it here, so we can all check, better than usless msg "Invalid Ip ..." — Yazan, May 19 '14 at 08:20
05-19 13:03:52.850: E/Fail 1(1242): android.os.NetworkOnMainThreadException 05-19 13:03:52.870: E/Fail 2(1242): java.lang.NullPointerException 05-19 13:03:52.870: E/Fail 3(1242): java.lang.NullPointerException 05-19 13:03:53.201: D/dalvikvm(1242): GC_CONCURRENT freed 178K, 2% free 10995K/11207K, paused 9ms+60ms, total 243ms — androidGenX, May 19 '14 at 08:31

user3559657 · Answer 1 · 2014-05-19T08:58:29.890

Run this in

public class MainActivity extends Activity {

String name;
String id;
InputStream is=null;
String result=null;
String line=null;
int code;

@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    final EditText e_id=(EditText) findViewById(R.id.editText1);
    final EditText e_name=(EditText) findViewById(R.id.editText2);
    Button insert=(Button) findViewById(R.id.button1);

    insert.setOnClickListener(new View.OnClickListener() {

    @Override
    public void onClick(View v) {
        // TODO Auto-generated method stub


          id = e_id.getText().toString();
          name = e_name.getText().toString();
        new loadData().execute();
    }
});
}


class loadData extends AsyncTask<String, Integer, String> {
private StringBuilder sb;
private ProgressDialog pr;
private HttpResponse req;
private InputStream is;

@Override
protected void onPreExecute() {
    super.onPreExecute();
Toast.makeText(getApplicationContext(), "Start", Toast.LENGTH_LONG).show();
}

@Override
protected String doInBackground(String... arg0) {

      ArrayList<NameValuePair> nameValuePairs = new ArrayList<NameValuePair>();

        nameValuePairs.add(new BasicNameValuePair("id",id));
        nameValuePairs.add(new BasicNameValuePair("name",name));

            try
            {
            HttpClient httpclient = new DefaultHttpClient();
                HttpPost httppost = new HttpPost("http://xxxxx/insert.php");
                httppost.setEntity(new UrlEncodedFormEntity(nameValuePairs));
                HttpResponse response = httpclient.execute(httppost); 
                HttpEntity entity = response.getEntity();
                is = entity.getContent();
                InputStreamReader ireader = new InputStreamReader(is);
                BufferedReader bf = new BufferedReader(ireader);
                sb = new StringBuilder();
                String line = null;
                while ((line = bf.readLine()) != null) {
                    sb.append(line);
                }
                Log.e("pass 1", "connection success ");
        }
            catch(Exception e)
        {
                Log.e("Fail 1", e.toString());
                Toast.makeText(getApplicationContext(), "Invalid IP Address",
                Toast.LENGTH_LONG).show();
        }
            return id;     





}

@Override
protected void onPostExecute(String result) {
    super.onPostExecute(result);
    pr.dismiss();
    Toast.makeText(getApplicationContext(), "End", Toast.LENGTH_LONG).show();

}

} }

its performing networking operation on its main thread. Run your code in AsyncTask

Can you explain how?? I am new to this – androidGenX May 19 '14 at 08:14 — androidGenX, May 19 '14 at 08:14
see the code i had updated ... – user3559657 May 19 '14 at 08:58 — user3559657, May 19 '14 at 08:58
Ty dude I managed it. But thanks for your help – androidGenX May 19 '14 at 09:05 — androidGenX, May 19 '14 at 09:05

score 2 · Answer 2 · answered May 19 '14 at 08:39

android.os.NetworkOnMainThreadException

this means you can't communicate with network from the UI thread, so, you have to use async task

create asyncTask class:

class insertTask extends AsyncTask<String, String, String> {
     protected String doInBackground(String... params) {
         String result = insert();
         return result ;
     }



     protected void onPostExecute(String result) {
         if(result.equals("OK"))....
         //after background is done, use this to show or hide dialogs
     }
 }

you need to execute task at onClick()

@Override
public void onClick(View v) {

    id = e_id.getText().toString();
    name = e_name.getText().toString();

    new insertTask().execute("");
}

and modify public void insert() to return some string telling what status is, OK, ERR, ...

Yazzan I am new to Async task, can you Edit my code and put accordingly. Because I am not getting it properly — androidGenX, May 19 '14 at 08:44
try to use this answer, its clear and simple, just give it a try — Yazan, May 19 '14 at 08:47

Invalid IP Address android

2 Answers2