sprintf() program undefined return value

Question

#include <stdio.h>
#include <stdlib.h>
//#include <wchar.h>

int main(int argc, char **argv)
{
     char *c = (char *)malloc(sizeof(char) * 30);

     if (argc < 2)
     {      
         fprintf(stderr, "%s", "argc < 2\n");
         exit(1);
     }

     sprintf(c, "sprintf() string : %s\t argc: %i", argv[1], argc);
     fprintf(stdout, "%s\n", c);
     fprintf(stdout, "%s", "Done!\n");
     free(c);

     return 0;
}

I have compiled this program on two compilers, and both produce the same run-time error. However I can't pin down this error. Did I format the string correctly in sprintf()? Is there something I forgot to account for?

I run this program with an argument of argv[1] = "Sunday"

Don't cast `malloc`: http://stackoverflow.com/questions/605845/do-i-cast-the-result-of-malloc — Barmar, May 23 '14 at 01:06
You've only allocated 30 bytes. You're trying to put 35 characters into it. — Barmar, May 23 '14 at 01:09

score 3 · Answer 1 · answered May 23 '14 at 01:10

You are setting c to 30 bytes in size at the malloc.

Then in the sprintf you are writting 28 bytes, plus the argv[1] string plus argc as string. This will almost certainly be more than 30 bytes.

You need to calculate the actual size you need to malloc for c properly. Or you should use snprintf instead of sprintf, which you can use to limit the number of characters written to 30 and avoid crashing.

score 2 · Answer 2 · answered May 23 '14 at 01:09

2

You print more than 30 chars to c. To cut off the output when this happens, instead of crashing, do:

snprintf(c, 30, "bla bla....

answered May 23 '14 at 01:09

M.M

138,810
21
208
365

sprintf() program undefined return value

2 Answers2