Spring RestTemplate - Overriding ResponseErrorHandler

Question

I am calling a ReST service through RestTemplate and trying to override ResponseErrorHandler in Spring 3.2 to handle custom error codes.

CustomResponseErrroHandler

public class MyResponseErrorHandler implements ResponseErrorHandler {

    @Override
    public boolean hasError(ClientHttpResponse response) throws IOException {
        boolean hasError = false;
        int rawStatusCode = response.getRawStatusCode();
        if (rawStatusCode != 200){
            hasError = true;
        }
        return hasError;
     }

    @Override
    public void handleError(ClientHttpResponse response) throws IOException {
        //String body = IOUtils.toString(response.getBody());
        throw new CustomServiceException(response.getRawStatusCode() , "custom Error");
   }
}

Spring framework invokes hasError method but not handleError, so I couldn't throw my custom exception. After delving into Spring RestTemplate source code, I realized that the code in handleResponseError method is causing the issue - It is looking for response.getStatusCode or response.getStatusText and throwing exception (as statusCode/statusText is null when Rest service throws exception) and it never calls either custom implemented or default handleError method in the next line.

Spring RestTemplate source code for handleResponse method:

private void handleResponseError(HttpMethod method, URI url, ClientHttpResponse response) throws IOException {
    if (logger.isWarnEnabled()) {
        try {
            logger.warn(method.name() + " request for \"" + url + "\" resulted in " +
response.getStatusCode() + " (" + response.getStatusText() + "); invoking error handler");
        }
        catch (IOException e) {
            // ignore
        }
    }
    getErrorHandler().handleError(response);
}

FYI, while service throws exception, I can read rawstatuscode but not statuscode from response

How to bypass this framework code and make call my custom handler? Thanks for your help in advance.

You can check bellow thread. https://stackoverflow.com/a/51805956/3073945 — Md. Sajedul Karim, Aug 12 '18 at 05:43
https://stackoverflow.com/questions/38093388/spring-resttemplate-exception-handling — pramodc84, Dec 04 '18 at 10:47

score 17 · Answer 1 · edited Oct 30 '18 at 01:17

Following link has useful information about Exception Flow for Spring ResponseErrorHandler .

Adding code here, just in-case the blog is down:

Code for ErrorHandler:

public class MyResponseErrorHandler implements ResponseErrorHandler {

    private static final Log logger = LogFactory.getLog(MyResponseErrorHandler.class);

    @Override
    public void handleError(ClientHttpResponse clienthttpresponse) throws IOException {

        if (clienthttpresponse.getStatusCode() == HttpStatus.FORBIDDEN) {
            logger.debug(HttpStatus.FORBIDDEN + " response. Throwing authentication exception");
            throw new AuthenticationException();
        }
    }

    @Override
    public boolean hasError(ClientHttpResponse clienthttpresponse) throws IOException {

        if (clienthttpresponse.getStatusCode() != HttpStatus.OK) {
            logger.debug("Status code: " + clienthttpresponse.getStatusCode());
            logger.debug("Response" + clienthttpresponse.getStatusText());
            logger.debug(clienthttpresponse.getBody());

            if (clienthttpresponse.getStatusCode() == HttpStatus.FORBIDDEN) {
                logger.debug("Call returned a error 403 forbidden resposne ");
                return true;
            }
        }
        return false;
    }
}

Code for using it in RestTemplate:

RestTemplate restclient = new RestTemplate();
restclient.setErrorHandler(new MyResponseErrorHandler());
ResponseEntity<String> responseEntity = clientRestTemplate.exchange(
                    URI,
                    HttpMethod.GET,
                    requestEntity,
                    String.class);
                response = responseEntity.getBody();

This seems like a pretty bad implementation of the hasError() method because it only returns true if the service returns a forbidden error. A much better implementation is one implemented here - https://stackoverflow.com/a/15685964/10792 — senfo, Aug 14 '19 at 17:20

score 4 · Answer 2 · edited Nov 09 '18 at 17:42

4

I don't see your RestTemplate code, but I assume you to set your ResponseErrorHandler for RestTemplate to use like:

RestTemplate restClient = new RestTemplate();
restClient.setErrorHandler(new MyResponseErrorHandler());

The exception is indeed thrown in handleError method. You can find how to throw CustomException using CustomResponseHandler from one of my previous answers.

edited Nov 09 '18 at 17:42

noob

774
1
10
23

answered May 24 '14 at 02:52

nilesh

14,131
7
65
79

Nilesh, I tried and it didn't work. To hit custom handleError it should first reach hanldeResponseError() method in RestTempalte and it decides which handleError() it should call but hanldeResponseError() is throwing exception as statuscode is null and it never reach next line. I provided RestTemplate handleResponseError() method code in previous post. FYI, I was trying through spring configuration, now I tried setting manually in code. Either way it didn't work – user3670450 May 27 '14 at 21:22
FYI, It is not reaching either custom or default HandleError() to throw CustomException as exception is thrown in caller method handleResponseError() as statuscode is null. – user3670450 May 27 '14 at 21:35
http://springinpractice.com/2013/10/07/handling-json-error-object-responses-with-springs-resttemplate – Ahmet Karakaya Jul 15 '16 at 17:40

Spring RestTemplate - Overriding ResponseErrorHandler

2 Answers2

Linked