Cannot assign to 'X' in 'Y' in Swift

Question

I have a dictionary with Structs in it. I am trying to assign the values of the struct when I loop through the dictionary. Swift is telling me cannot assign to 'isRunning' in 'blockStatus'. I haven't been able to find anything in the docs on this particular immutability of dictionaries or structs.
Straight from the playground:

import Cocoa

struct BlockStatus{
 var isRunning = false
 var timeGapForNextRun = UInt32(0)
 var currentInterval = UInt32(0) 
}

var statuses = ["block1":BlockStatus(),"block2":BlockStatus()]

for (block, blockStatus) in statuses{
 blockStatus.isRunning = true
}

cannot assign to 'isRunning' in 'blockStatus'
blockStatus.isRunning = true

This does work if I change the struct to a class.

I am guessing it has something to do with the fact that structs are copied and classes are always referenced?

EDIT: So even if it is copying it.. Why can't I change it? It would net me the wrong result but you can change members of constants just not the constant themselves. For example you can do this:

class A {
    var b = 5
}

let a = A()
a.b = 6

score 22 · Accepted Answer · edited Jun 20 '20 at 09:12

22

Your guess is true.

By accessing blockStatus, you are creating a copy of it, in this case, it's a constant copy (iterators are always constant).

This is similar to the following:

var numbers = [1, 2, 3]

for i in numbers {
   i = 10  //cannot assign here
}

References:

Control Flow

In the example above, index is a constant whose value is automatically set at the start of each iteration of the loop.

Classes and Structures

A value type is a type that is copied when it is assigned to a variable or constant, or when it is passed to a function. [...] All structures and enumerations are value types in Swift

Methods

Structures and enumerations are value types. By default, the properties of a value type cannot be modified from within its instance methods.

However, if you need to modify the properties of your structure or enumeration within a particular method, you can opt in to mutating behavior for that method. The method can then mutate (that is, change) its properties from within the method, and any changes that it makes are written back to the original structure when the method ends. The method can also assign a completely new instance to its implicit self property, and this new instance will replace the existing one when the method ends.

You can opt in to this behavior by placing the mutating keyword before the func keyword for that method:

edited Jun 20 '20 at 09:12

Community

1
1

answered Jun 20 '14 at 13:43

Sulthan

128,090
22
218
270

But even if it is a copy I should be able to change the copy no? It would not give me the right result but... It is a constant but you can change members of constants. See my edit. – Johnston Jun 20 '14 at 13:50
@Johnston Not on a constant struct. – Sulthan Jun 20 '14 at 13:51
Aha. You are correct. Do you know where it says that? – Johnston Jun 20 '14 at 13:53
@Johnston Added a couple of references. – Sulthan Jun 20 '14 at 14:02
Good answer. I was going crazy about this. I did some further reading and, @Johnston, I have found where it says that the properties of constant structures cannot be changed. [Stored Properties of Constant Structure Instances](https://developer.apple.com/library/ios/documentation/Swift/Conceptual/Swift_Programming_Language/Properties.html#//apple_ref/doc/uid/TP40014097-CH14-XID_382) – alondono Nov 09 '14 at 01:28
I was running into this problem because I had a protocol `Foo`. If you have an array of `Foo` and you iterate through the array, you cannot set the properties of the array members because Foo might be a struct. By making `Foo` a `class` protocol I made Swift happy again. – phatmann Nov 27 '14 at 15:40

score 6 · Answer 2 · edited Apr 09 '15 at 14:42

6

You could loop through the array with an index

for index in 0..<statuses.count {
    // Use your array - statuses[index]
}

that should work without getting "cannot assign"

edited Apr 09 '15 at 14:42

Stuart

36,683
19
101
139

answered Jun 22 '14 at 10:18

StrangeDays

352
5
4

I can't edit this reply, as it should contain at least 6 characters :], so I will correct you here. 1) Correct operator is "..." not ".."; 2) count should be -1 otherwise you will crash the app – pasevin Jan 28 '15 at 18:44
@pasevin Edited it for you. – Michal Mar 12 '15 at 14:38
@pasevin Better still, use the half-open range operator. – Stuart Apr 09 '15 at 14:46
agree this is clever ;] – pasevin Apr 09 '15 at 17:13

Antoine · Answer 3 · 2015-05-05T07:02:23.707

4

If 'Y' in this case is a protocol, subclass your protocol to class. I had a protocol:

 protocol PlayerMediatorElementProtocol {
      var playerMediator:PlayerMediator { get }
 }

and tried to set playerMediator from within my player mediator:

element.playerMediator = self

Which turned into the error cannot asign 'playerMediator' in 'element'

Changing my protocol to inherit from class fixed this issue:

 protocol PlayerMediatorElementProtocol : class {
      var playerMediator:PlayerMediator { get }
 }

Why should it inherit from class?

The reason it should inherit from class is because the compiler doesn't know what kind your protocol is inherited by. Structs could also inherit this protocol and you can't assign to a property of a constant struct.

edited May 05 '15 at 07:02

answered Apr 29 '15 at 15:07

Antoine

23,526
11
88
94

Had the same issue except the property in my protocol was defined with `{get set}`. Adding `class` fixed it, but it seems like you should be able to set without it. Anyone know why class is needed? – RyanM May 05 '15 at 01:20
I've updated my answer with the reason it should inherit from `class`. It's because the possibility of inheritance by structs – Antoine May 05 '15 at 07:02

Cannot assign to 'X' in 'Y' in Swift

3 Answers3

Linked