JSON ListVIew in Fragment - doInBackground() error

Question

I'm trying to get list from JSON in the fragment on button click. Just when I thought I had all figured out I hit the wall. So if anyone can take a look and if you know whats wrong please explain it to me since I'm android beginner(php and js only).

public class ExampleFragment extends Fragment {

    ListView list;
    TextView id;
    TextView zip;
    TextView city;
    TextView state;
    TextView country;
    Button Btngetdata;

    ArrayList<HashMap<String, String>> oslist = new ArrayList<HashMap<String, String>>();

    //URL to get JSON Array
    private static String url = "http://url.com/web_services/get_cities.php";

    //JSON Node Names
    private static final String TAG_ARRAY = "cities";
    private static final String TAG_ID = "id";
    private static final String TAG_CITY = "city_text";
    private static final String TAG_ZIP = "zipcode_text";
    private static final String TAG_STATE = "state_text";
    private static final String TAG_COUNTRY = "country_text";

    JSONArray cities = null;

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {
        // Inflate the layout for this fragment
        return inflater.inflate(R.layout.example_fragment, container, false);

    }

    @Override
    public void onActivityCreated(Bundle savedInstanceState) {
        // TODO Auto-generated method stub
        super.onActivityCreated(savedInstanceState);

        oslist = new ArrayList<HashMap<String, String>>();
        Btngetdata = (Button)getView().findViewById(R.id.getdata);
        Btngetdata.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                new JSONParse().execute();  
            }
        });

    }

    private class JSONParse extends AsyncTask<String, String, JSONObject> {

        private ProgressDialog pDialog;
        JSONparser jParser = new JSONparser();
        private JSONObject json;

        @Override
        protected void onPreExecute() {
            super.onPreExecute();
            city = (TextView)getView().findViewById(R.id.city);
            state = (TextView)getView().findViewById(R.id.state);
            country = (TextView)getView().findViewById(R.id.country);
            id = (TextView)getView().findViewById(R.id.id);
            zip = (TextView)getView().findViewById(R.id.zip);

            pDialog = new ProgressDialog(getActivity());
            pDialog.setMessage("Getting Data ...");
            pDialog.setIndeterminate(false);
            pDialog.setCancelable(true);
            pDialog.show();


        }

        @Override
        protected JSONObject doInBackground(String... args) {

            // Getting JSON from URL
            json = jParser.getJSONFromUrl(url);

            return json;
        }

        @Override
        protected void onPostExecute(JSONObject json) {

            pDialog.dismiss();
            try {
                 // Getting JSON Array from URL
                 cities = json.getJSONArray(TAG_ARRAY);

                 for(int i = 0; i < cities.length(); i++){

                     JSONObject c = cities.getJSONObject(i);

                     // Storing  JSON item in a Variable
                     String id = c.getString(TAG_ID);
                     String zip = c.getString(TAG_ZIP);
                     String city = c.getString(TAG_CITY);
                     String state = c.getString(TAG_STATE);
                     String country = c.getString(TAG_COUNTRY);

                     // Adding value HashMap key => value
                     HashMap<String, String> map = new HashMap<String, String>();
                     map.put(TAG_ID, id);
                     map.put(TAG_ZIP, zip);
                     map.put(TAG_CITY, city);
                     map.put(TAG_STATE, state);
                     map.put(TAG_COUNTRY, country);

                     oslist.add(map);

                     list = (ListView)getView().findViewById(R.id.list);

                     ListAdapter adapter = new SimpleAdapter(getActivity(), oslist,
                         R.layout.list_item,
                         new String[] { TAG_CITY, TAG_STATE, TAG_COUNTRY, TAG_ID, TAG_ZIP }, new int[] {
                             R.id.city, R.id.state, R.id.country, R.id.id, R.id.zip});
                     list.setAdapter(adapter);
                     list.setOnItemClickListener(new AdapterView.OnItemClickListener() {
                         @Override
                         public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
                             Toast.makeText(getActivity(), "You Clicked at "+oslist.get(+position).get("name"), Toast.LENGTH_SHORT).show();
                         }
                     });
                 }
            } catch (JSONException e) {
              e.printStackTrace();
            }
        }
    }
}

EDIT: Logcat posting enter image description here

You need to add access to internet permission in manifest file. http://stackoverflow.com/questions/2169294/how-to-add-manifest-permission-to-android-application — Gaurav Gupta, Jun 24 '14 at 12:33

score 2 · Accepted Answer · answered Jun 24 '14 at 12:31

2

<manifest xlmns:android...>
     <uses-permission android:name="android.permission.INTERNET"/>
</manifest>

answered Jun 24 '14 at 12:31

DroidBender

7,762
4
28
37

Could you add a little bit of background, for future references – Blackbelt Jun 24 '14 at 12:33

score 2 · Answer 2 · answered Jun 24 '14 at 12:34

2

Everything is clear from LogCat: you forgot to add permission to access Internet. Add it to the Manifest:

<uses-permission android:name="android.permission.INTERNET"/>

answered Jun 24 '14 at 12:34

nikis

11,166
2
35
45

score 2 · Answer 3 · answered Jun 24 '14 at 12:34

2

Your logcat clearly says Permission Denied (Missing Internet Permission), You need to add following line in your Manifest.xml file

<uses-permission android:name="android.permission.INTERNET"/>

answered Jun 24 '14 at 12:34

madteapot

2,208
2
19
32

score 0 · Answer 4 · edited Jan 02 '17 at 06:24

For future reference add this following code to avoid adding internet permission always for different application:

int PERMISSION_ALL = 1;
String[] PERMISSIONS = {Manifest.permission.READ_CONTACTS, Manifest.permission.WRITE_CONTACTS, Manifest.permission.WRITE_EXTERNAL_STORAGE, Manifest.permission.READ_SMS, Manifest.permission.CAMERA};

if(!hasPermissions(this,PERMISSIONS))
{
    ActivityCompat.requestPermissions(this, PERMISSIONS, PERMISSION_ALL);
}



public static boolean hasPermissions(Context context, String... permissions)
    {
        if (android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.M && context != null && permissions != null)
        {
            for (String permission : permissions)
            {
                if (ActivityCompat.checkSelfPermission(context, permission) != PackageManager.PERMISSION_GRANTED)
                {
                    return false;
                }
            }
        }
        return true;
    }

it will ask only for those permissions which are necessary for the applications — Vaibhav Joshi, Jan 02 '17 at 06:11

JSON ListVIew in Fragment - doInBackground() error

4 Answers4