Angular - function inside .factory

Question

I'm trying to run a function inside .factory to get posts, but I get an undefined error on my controller.

.factory('Portfolio', function($http, $log) {
  //get jsonp
    this.getPosts = function($scope) {
        $http.jsonp("http://test.uxco.co/json-test.php?callback=JSON_CALLBACK")
            .success(function(result) {
                $scope.posts = $scope.posts.concat(result);
                $scope.$broadcast("scroll.infiniteScrollComplete");
            });
    };
});


.controller('PortfolioCtrl', function($scope, Portfolio) {
    $scope.posts = [];
    Portfolio.getPosts($scope);

Thanks!

Fixed - having a doh moment! used .service instead – user3930160 Aug 12 '14 at 09:41 — user3930160, Aug 12 '14 at 09:41

score 1 · Answer 1 · edited May 23 '17 at 12:11

What you wrote is a service not a factory. so you either

change it to be .service instead of .factory.
or return the function inside an object like this

.factory('Portfolio', function($http, $log) {
    //get jsonp
    return {
        getPosts: function($scope) {
            $http.jsonp()
                .success(function(result) {
                    $scope.posts = $scope.posts.concat(result);
                    $scope.$broadcast("scroll.infiniteScrollComplete");
                });
        };
    }

});

check the difference between service and factory

score 0 · Answer 2 · answered Aug 12 '14 at 09:41

Use .factory code like this

.factory('Portfolio', function($http, $log) {
  //get jsonp
   return{
       getPosts: function($scope) {
        $http.jsonp("http://test.uxco.co/json-test.php?callback=JSON_CALLBACK")
        .success(function(result) {
            $scope.posts = $scope.posts.concat(result);
            $scope.$broadcast("scroll.infiniteScrollComplete");
        });
      };
    }
});

Angular - function inside .factory

2 Answers2