JavaScript submit button onclick redirect not working

Question

Why this JavaScript code is not redirecting to the URL ? What is wrong with this code?

function submitform() {
    var hiddenFieldValue = document.getElementById('course').value;
    alert("inindonesia.org/marketplace/tags/"+hiddenFieldValue);
    window.location.href= "inindonesia.org/marketplace/tags/"+hiddenFieldValue); 
    return false;
}

HTML code

<form autocomplete="off" method="POST">
        <p>
            Course Name <label>:</label>
            <input type="text" name="course" id="course" />
            <!--input type="button" value="Get Value" /-->
            <input type="text" name="course_val" id="course_val" />
        </p>
        <input type="submit" value="Submit" onClick="submitform()"/>
</form>

Iam not sure but use a full URL like http://inidonesia.org/ – Webice Aug 13 '14 at 07:54 — Webice, Aug 13 '14 at 07:54
Yes have done @Webice.. But, it still no luck – Mimma Ruchaini Aug 13 '14 at 07:56 — Mimma Ruchaini, Aug 13 '14 at 07:56
and there is an extra `)` in the window.location.href line. – TJ- Aug 13 '14 at 07:59 — TJ-, Aug 13 '14 at 07:59

score 2 · Answer 1 · answered Aug 13 '14 at 08:14

As you are relying on button click, what is the need of the form?? As you put that in <form &rt; it is not working. remove form, it will work

        <p>
        Course Name <label>:</label>
        <input type="text" name="course" id="course" />
        <!--input type="button" value="Get Value" /-->
        <input type="text" name="course_val" id="course_val" />
    </p>
    <input type="submit" value="Submit" onClick="submitform()"/>

Remove form.

score 1 · Answer 2 · answered Aug 13 '14 at 07:58

You need http:// on the URL. You code updated:

function submitform(){
    var hiddenFieldValue = document.getElementById('course').value;
    alert("inindonesia.org/marketplace/tags/"+hiddenFieldValue);
    window.location.href= "http://inindonesia.org/marketplace/tags/"+hiddenFieldValue); 
    return false;
}

score 0 · Answer 3 · edited May 23 '17 at 12:14

0

You should use only

window.location = url;

or

window.location.replace = url;

instead off

window.location.href

cause that simulates a link

here is the discussion

How to redirect to another webpage in JavaScript/jQuery?

edited May 23 '17 at 12:14

Community

1
1

answered Aug 13 '14 at 08:00

Webice

592
4
15

Yes i have change to window.location.replace = url; and add 'http://'.. but it still not redirect to url.. @Webice – Mimma Ruchaini Aug 13 '14 at 08:09

score 0 · Answer 4 · answered Aug 13 '14 at 08:00

0

you are doing this :

 window.location.href= "inindonesia.org/marketplace/tags/"+hiddenFieldValue);

change it to this :

 window.location.href= "inindonesia.org/marketplace/tags/"+hiddenFieldValue;

NOTE THE ')' that i deleted at the end of the line.

answered Aug 13 '14 at 08:00

Youness

1,468
1
9
19

JavaScript submit button onclick redirect not working

4 Answers4