How x.clone().equals(x) is True

Question

I have tried this implementation but i got false for the class x

x.clone().equals(x)

Class X :

public class X implements Cloneable{
    private String name;
    public String getName() {
        return name;
    }
    public void setName(String name) {
        this.name = name;
    }
    protected Object clone()throws CloneNotSupportedException {
        return super.clone();       
    }

}

Main class :

public class ObjectCloneCopy {
  public static void main(String[] args) throws CloneNotSupportedException {
    X x = new X();
    System.out.println("x.clone().equals(x) - " + x.clone().equals(x));
  }
}

Is it mandatory to overload the hashcode() and equals() to get this True ?

Without overriding these methods how this statement gives true?

X x1 = x;
x1.equals(x)

Explain how that could be true, i have seen in this link

[Didn't you just ask this question 2 minutes ago?](http://stackoverflow.com/questions/25284297/how-x-clone-equalsx-is-true) Don't delete your questions and just repost them. — Jeroen Vannevel, Aug 13 '14 at 11:20
@JeroenVannevel Yes i asked after i deleted, i thought i may asked wrong. after i felt i should clarified my doubts so again undeleted... — R D, Aug 13 '14 at 11:23
Without override hashcode and equals why this statement gives true : X x1 = x; x1.equals(x) — R D, Aug 13 '14 at 11:38
possible duplicate of [Java == vs equals() confusion](http://stackoverflow.com/questions/7520432/java-vs-equals-confusion) — Raedwald, Aug 13 '14 at 11:55

score 5 · Accepted Answer · answered Aug 13 '14 at 11:19

5

You need to override equals() and hashCode() method in your X class.

Else you can't get the correct result from x.clone().equals(x)

answered Aug 13 '14 at 11:19

Ruchira Gayan Ranaweera

34,993
17
75
115

Is it mandatory to overload the hashcode() and equals() to get this True ? – R D Aug 13 '14 at 11:22
1

@RajavelD Not overloading it is overriding . When ever you are creating a `Java` Object make sure you are overriding them. – Ruchira Gayan Ranaweera Aug 13 '14 at 11:22
1

It's *overriding*, not *overloading*. Those are 2 different concepts. Look into how `.equals()` works and what `.clone()` does, the source is freely available to you. – Jeroen Vannevel Aug 13 '14 at 11:24
@RajavelD since you are not overriding you are getting wrong answer – Ruchira Gayan Ranaweera Aug 13 '14 at 11:33
@RuchiraGayanRanaweera with out override what is output of this statement X x1 = x; x1.equals(x) – R D Aug 13 '14 at 11:36
@RajavelD since you are not overriding you are getting wrong answer – Ruchira Gayan Ranaweera Aug 13 '14 at 11:42
I understood for x.clone().equals(x). I am asking for how X x1 = x; x1.equals(x) gives true without overriding? – R D Aug 13 '14 at 11:44
1

@RajavelD `eqals()` method will return either `true` or `false` definably. Since `equals()` not have in `X` `x1` and `x` are considered as same object or both referring same reference. Without overriding it will check the `equals()` in Object class `public boolean equals(Object obj) { return (this == obj); }` – Ruchira Gayan Ranaweera Aug 13 '14 at 11:46
@Raedwald I didn't care about that. If you care you can flag it and vote for close. You don't need to ask from others to do so. – Ruchira Gayan Ranaweera Aug 13 '14 at 12:01

score 1 · Answer 2 · answered Aug 13 '14 at 11:25

Object#clone returns independent of clonning object, so two independent object may not be equals.

As per documentation -

Object#clone -

Creates and returns a copy of this object. The precise meaning of "copy" may depend on the class of the object. . The general intent is that -

x.clone() != x // true
x.clone().getClass() == x.getClass() // true

and

x.clone().equals(x) // will be true, this is not an absolute requirement.

By convention, the returned object should be obtained by calling super.clone. If a class and all of its superclasses (except Object) obey this convention, it will be the case that x.clone().getClass() == x.getClass().

score 1 · Answer 3 · answered Aug 13 '14 at 12:00

Need to override `equals()` and `hashCode()` method in the class `X`.

If not you can't get the correct true for x.clone().equals(x)

For

X x1 = new X()
x1.equals(x)

Since not overriding equals()

x1 and x are considered as same object of X class so it return true

Without overriding it will check the equals() in Object class

public boolean equals(Object obj) {
     return (this == obj);     
}

score 0 · Answer 4 · edited May 23 '17 at 11:53

0

Try first to equals() and hashCode() and make thier result based on class attribute value so that when you override , the cloned instance should return the same value of hashCode() and the equals code should return true. check this it may help you .

edited May 23 '17 at 11:53

Community

1
1

answered Aug 13 '14 at 11:46

Mifmif

3,132
18
23

score 0 · Answer 5 · answered Aug 15 '14 at 19:00

First Question : x.clone().equals(x) It will return false.

We need override equals & hashcode.Because of the following reason we need to do.

1) Clone will create new instance of x. Reference of two instances are different since both are different reference.

2) If equals & hashcode methods are not overridden, Super class Object#equals will be invoked. This will check the memory location of the object. As per our earlier point both have different address, so it will false.

Second Question : X x1 = x x1.equals(x) return true.

1) x1,x are same object and same location.

2) So even override equals & hashcode methods are not overridden, it will check the memory location and will return true.

How x.clone().equals(x) is True

5 Answers5