Button inside ListView unable to Receive OnClick?

Question

Currently, my listView is sitting inside a fragment. However, the buttons inside my view are not able to receive the on click event whenever I tap on them.

I am not sure what to do.

Here is my code:

public class ViewInvitationsCursorAdapter extends CursorAdapter {

private Activity activity;

private int layout;
private Cursor cr;
private final LayoutInflater inflater;
private Fragment f;
private boolean displayAcceptDeny;

public ViewInvitationsCursorAdapter(Activity activity, Fragment f,
        int layout, Cursor c, boolean displayAcceptDeny) {
    super(activity, c);
    this.layout = layout;
    this.activity = activity;
    this.inflater = LayoutInflater.from(activity);
    this.cr = c;
    this.f = f;
    this.displayAcceptDeny = displayAcceptDeny;
}

public static class ViewHolder {

    public TextView sender;
    public TextView sender_email;
    public TextView author_role;
    public Button deny;
    public Button accept;
    public Button cancel;
}

@Override
public View newView(Context context, Cursor cursor, ViewGroup parent) {

    ViewHolder holder = new ViewHolder();
    View view = inflater.inflate(layout, parent, false);

    holder.sender = (TextView) view.findViewById(R.id.connection_sender);
    holder.sender_email = (TextView) view
            .findViewById(R.id.connection_sender_email);

    holder.author_role = (TextView) view.findViewById(R.id.connection_role);

    holder.accept = (Button) view.findViewById(R.id.connection_allow);
    holder.deny = (Button) view.findViewById(R.id.connection_deny);
    holder.cancel = (Button) view.findViewById(R.id.connection_cancel);

    view.setTag(holder);
    return view;
}


@Override
public void bindView(View view, Context context, final Cursor cursor) {
    // .bindView(view, context, cursor);
    final ViewHolder holder = (ViewHolder) view.getTag();

    int sender_index = cursor
            .getColumnIndexOrThrow(FamilyDBHelper.COLUMN_SENDER_BY_NAME);
    int sender_email_index = cursor
            .getColumnIndexOrThrow(FamilyDBHelper.COLUMN_SENDER_BY_EMAIL);

    String senderString = cursor.getString(sender_email_index);

    int author_role_name = cursor
            .getColumnIndexOrThrow(FamilyDBHelper.COLUMN_RELATIONTYPE_NAME);
    int message_index = cursor
            .getColumnIndexOrThrow(FamilyDBHelper.COLUMN_MESSAGE);

    holder.sender.setText(cursor.getString(sender_index));

    holder.author_role.setText(cursor.getString(author_role_name));
    holder.sender_email.setText(cursor.getString(sender_email_index));



    holder.cancel.setVisibility(View.VISIBLE);
    // setUpCancel(view, cursor);
    holder.cancel.setOnClickListener(new OnClickListener() {

        @Override
        public void onClick(View arg0) {

              Log.i("cancel", "cancel clicked!");

        }
    });

}

protected void setUpAcceptDeny(View view, final Cursor cursor) {
    final ViewHolder holder = (ViewHolder) view.getTag();

    holder.accept.setOnClickListener(new View.OnClickListener() {

        @Override
        public void onClick(View arg0) {
            Log.i("accept", "accept clicked!");
        }
    });
    holder.deny.setOnClickListener(new View.OnClickListener() {

        @Override
        public void onClick(View arg0) {
            Log.i("deny", "deny clicked!");
        }
    });
}

}

Here is the xml for each of the items:

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    android:id="@+id/connection_item_row_layout"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:orientation="vertical"
    android:paddingBottom="8dp"
    android:paddingLeft="8dp"
    android:paddingRight="8dp"
    android:paddingTop="8dp" >

    <LinearLayout
        android:id="@+id/connection_item_info_layout"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:orientation="horizontal" >

        <RelativeLayout
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:layout_gravity="left"
            android:layout_weight="1"
            android:orientation="vertical" >

            <TextView
                android:id="@+id/connection_sender"
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:textColor="#000000"
                android:textSize="16sp"
                android:textStyle="bold"
                tools:text="ANDROID: PREFERENCEFRAGMENTCOMPAT" >
            </TextView>

            <TextView
                android:id="@+id/connection_sender_email"
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:layout_below="@+id/connection_sender"
                android:textColor="#000000"
                android:textSize="14sp"
                tools:text="ANDROID: PREFERENCEFRAGMENTCOMPAT" >
            </TextView>

            <TextView
                android:id="@+id/connection_role"
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:layout_below="@+id/connection_sender_email"
                android:textColor="#000000"
                android:textSize="14sp"
                 >
            </TextView>
        </RelativeLayout>

    </LinearLayout>

    <LinearLayout
        android:layout_width="fill_parent"
        android:layout_height="wrap_content"
        android:layout_below="@+id/connection_item_info_layout"
        android:orientation="horizontal"
        android:paddingBottom="1.0dip"
        android:paddingLeft="4.0dip"
        android:paddingRight="4.0dip"
        android:paddingTop="5.0dip" >

        <Button
            android:id="@+id/connection_allow"
            android:layout_width="0.0dip"
            android:layout_height="wrap_content"
            android:layout_weight="1.0"
            android:text="Allow"
            android:background="@color/green"
            android:textColor="@color/white"
            android:visibility="gone" />

        <Button
            android:id="@+id/connection_deny"
            android:layout_width="0.0dip"
            android:layout_height="wrap_content"
            android:layout_weight="1.0"
             android:background="@color/red"
             android:textColor="@color/white"
            android:text="Deny"
            android:visibility="gone" />
    </LinearLayout>

    <LinearLayout
        android:layout_width="fill_parent"
        android:layout_height="wrap_content"
        android:layout_below="@+id/connection_item_info_layout_request"
        android:orientation="horizontal"
        android:paddingBottom="1.0dip"
        android:paddingLeft="4.0dip"
        android:paddingRight="4.0dip"
        android:paddingTop="5.0dip" >

        <Button

            android:id="@+id/connection_cancel"
            android:layout_width="0.0dip"
             android:background="@color/red"
             android:textColor="@color/white"

            android:layout_height="wrap_content"
            android:layout_weight="1.0"
            android:text="Cancel Request"
            android:visibility="gone" />
    </LinearLayout>

</LinearLayout>

@Maddy: I reduced the code in order to try and pinpoint where the problem may have been. — Faytll, Aug 16 '14 at 11:14
@Krylez: none of those solutions worked for me. Does it change if my listview is inside a fragment? — Faytll, Aug 16 '14 at 11:27

score 0 · Answer 1 · answered Aug 16 '14 at 05:34

0

Add this line to your list item xml file.

android:descendantFocusability="blocksDescendants"

answered Aug 16 '14 at 05:34

Sathish

33
4

Does not work. Unfortunately, the test fails when I add it to the LinearLayout that wraps the entire item view. – Faytll Aug 16 '14 at 11:21

NavinRaj Pandey · Answer 2 · 2014-08-16T13:04:36.967

if you set clicklistener inside newView method like this it should work. I generally user getView() for this method and there has never been a problem..

@Override public View getView(Context context, View View, ViewGroup parent) {

ViewHolder holder = new ViewHolder();
LayoutInflater inflater = (LayoutInflater) context
                .getSystemService(Context.LAYOUT_INFLATER_SERVICE);
         View = inflater.inflate(R.layout.your_layout_file_id, parent,
                false);

holder.sender = (TextView) view.findViewById(R.id.connection_sender);
holder.sender_email = (TextView) view
        .findViewById(R.id.connection_sender_email);

holder.author_role = (TextView) view.findViewById(R.id.connection_role);

holder.accept = (Button) view.findViewById(R.id.connection_allow);
holder.deny = (Button) view.findViewById(R.id.connection_deny);
holder.cancel = (Button) view.findViewById(R.id.connection_cancel);

view.setTag(holder);

holder.cancel.setOnClickListener(new OnClickListener() {

    @Override
    public void onClick(View arg0) {

          Log.i("cancel", "cancel clicked!");

    }
});

return view;

}

Note that my code is for getView() method and this is a way to implement a custom adapter for ListView — NavinRaj Pandey, Aug 16 '14 at 13:07

Button inside ListView unable to Receive OnClick?

2 Answers2