PHP - callback once array_walk has completed

Question

I am trying to run a function for every element in an array using array_walk and try and catch so i can tell if any elements haven't run through the function successfully.

Once all elements have run through the function i need to respond with a complete callback.

In my code below though the complete json_ecnode is being run everytime rather than at the very end. What am i doing wrong? Also is this the most efficient way to do this?

$products = array('shirt','skirt','jumper','lingerie','makeup','top','trousers','coats');

$i = 0;
function createProducts(&$item, $key){
    try {
        // try something
    }
    catch(Exception $e) {
        // error
    }
    $i++;
    if($i > count($products)) { json_encode('complete'); }
}

array_walk($products, 'createProducts');

If you'd activate error reporting, you'd see your problem: variable scope. Read http://stackoverflow.com/a/16959577/476. But what you're trying to do here seems extremely odd from front to back. — deceze, Sep 18 '14 at 08:46

score 1 · Accepted Answer · answered Sep 18 '14 at 08:52

Well you could do something like this:

$products = array('shirt','skirt','jumper','lingerie','makeup','top','trousers','coats');
$count = count($products);
$i = 0;
array_walk($products, function(&$item, $key) use (&$i, $count){ // using anonymous
    try {
        // try something
        echo "<strong>$item</strong><br/>";
    }
    catch(Exception $e) {
        // error
    }

    $i++;
    if($i == $count) {

        echo 'completed at ' . $i;
        // execute something
    }
});

score 0 · Answer 2 · answered Sep 18 '14 at 08:46

0

The $i will always be 1, because every time you execute the function you get a new instance of that variable.

answered Sep 18 '14 at 08:46

smoove

3,920
3
25
31

score 0 · Answer 3 · answered Sep 18 '14 at 08:56

Additionally to Ghost answer, here is a way to do it with an anonymous call, but you still define the function previously, and not right when you use it. (Which is better if you intent to re-use it later on)

$products = array('shirt','skirt','jumper','lingerie','makeup','top','trousers','coats');

$i = 0;
$callback = function (&$item, $key) use ($i) {
    try {
        // try something
    }
    catch(Exception $e) {
        // error
    }
    $i++;
    if($i > count($products)) { json_encode('complete'); }
};

array_walk($products, $callback);

PHP - callback once array_walk has completed

3 Answers3