Swift UITableView reloadData in a closure

Question

I believe I'm having an issue where my closure is happening on a background thread and my UITableView isn't updating fast enough. I am making a call to a REST service and in my closure i have a tableView.reloadData() call but it takes a few seconds for this to happen. How do I make the data reload faster (perhaps on the main thread?)

REST Query Function - using SwiftyJSON library for Decoding

func asyncFlightsQuery() {
    var url : String = "http://127.0.0.1:5000/flights"
    var request : NSMutableURLRequest = NSMutableURLRequest()
    request.URL = NSURL(string: url)
    request.HTTPMethod = "GET"

    NSURLConnection.sendAsynchronousRequest(request, queue: NSOperationQueue(), completionHandler:{ (response:NSURLResponse!, networkData: NSData!, error: NSError!) -> Void in
        var error: AutoreleasingUnsafeMutablePointer<NSError?> = nil


        // Parse with SwiftyJSON
        let json = JSON(data: networkData)

        // Empty out Results array
        self.resultArray = []

        // Populate Results Array
        for (key: String, subJson: JSON) in json["flights"] {
            print ("KEY: \(key) ")
            print (subJson["flightId"])
            print ("\n")

            self.resultArray.append(subJson)
        }

        print ("Calling reloadData on table..??")
        self.tableView.reloadData()


    })
}

Once self.tableView.reloadData() is called in my debugger

Kirsteins · Accepted Answer · 2017-11-06T08:12:13.590

107

UIKit isn't thread safe. The UI should only be updated from main thread:

dispatch_async(dispatch_get_main_queue()) {
    self.tableView.reloadData()
}

Update. In Swift 3 and later use:

DispatchQueue.main.async {
    self.tableView.reloadData()
}

edited Nov 06 '17 at 08:12

answered Oct 09 '14 at 11:40

Kirsteins

27,065
8
76
78

1

Correct code should be: dispatch_async(dispatch_get_main_queue(), {self.tableView.reloadData()}) – Jeef Oct 09 '14 at 12:16
Sorry about that, fixed. – Kirsteins Oct 09 '14 at 12:18
2

Shall we not use [weak self] instead of self to avoid retain cycles? – G.Abhisek Sep 02 '16 at 14:55
2

@G.Abhisek not required as the dispatch_async will never capture the block that captures strong self. – Kirsteins Sep 02 '16 at 18:32
Can you please explain a bit more clearly with respect to the context ? – G.Abhisek Sep 06 '16 at 12:44
1

@G.Abhisek `dispatch_async` will only hold the block that retains `self` only till the block is executed. Also the code that calls `dispatch_async` do not hold any reference to its internals, so there are no risk of retain cycles. – Kirsteins Sep 06 '16 at 12:47
@Kirsteins everywhere it is written that the UI should be updated from the main thread using dispatchQueue only but can you please explain as in why should it be like that. – Nishad Arora Apr 27 '18 at 04:27

score 5 · Answer 2 · answered Aug 06 '15 at 10:56

5

You can also reload UITableView like this

self.tblMainTable.performSelectorOnMainThread(Selector("reloadData"), withObject: nil, waitUntilDone: true)

answered Aug 06 '15 at 10:56

Anand Suthar

3,678
2
30
52

where should this function put? in viewdidload ? – Eric Chong Nov 16 '17 at 12:47

score 3 · Answer 3 · answered Nov 13 '16 at 13:45

3

With Swift 3 use

DispatchQueue.main.async {
    self.tableView.reloadData()
}

answered Nov 13 '16 at 13:45

Sal

1,230
13
21

will this freeze UI? – Yaroslav Dukal Feb 04 '17 at 08:37
No, this doesn't freeze the UI. – Sal Feb 06 '17 at 19:42

bubbaspike · Answer 4 · 2021-05-26T15:59:30.157

2

You can also update the main thread using NSOperationQueue.mainQueue(). For multithreading, NSOperationQueue is a great tool.

One way it could be written:

NSOperationQueue.mainQueue().addOperationWithBlock({
     self.tableView.reloadData()       
})

Update: DispatchQueue is the way to go for this

Update 2: Use DispatchQueue solution as seen in accepted answer above

edited May 26 '21 at 15:59

answered Aug 03 '16 at 14:20

bubbaspike

101
6

score 1 · Answer 5 · answered Feb 04 '17 at 08:39

1

SWIFT 3:

OperationQueue.main.addOperation ({
     self.tableView.reloadData()
})

answered Feb 04 '17 at 08:39

Yaroslav Dukal

3,894
29
36

SudhakarH · Answer 6 · 2021-05-07T05:06:44.840

0

DispatchQueue.main.async {
    self.tableView.reloadData()
}

Do this to update the UI on the main thread. Using this method it will bring update the table view and reflect the data in the UI.

edited May 07 '21 at 05:06

answered Sep 04 '20 at 07:28

SudhakarH

541
5
16

score 0 · Answer 7 · answered Oct 13 '21 at 14:07

I suggest to improve it one step further (starting from swift 3):

struct UIHelper {
    static func performUpdate(using closure: @escaping () -> Void) {
        if Thread.isMainThread {
            closure()
        } else {
            DispatchQueue.main.async(execute: closure)
        }
    }
}

And then:

UIHelper.performUpdate {
    self.tableView.reloadTable()
}

The reason for this is that sometimes the call is made on main thread, so there's no need to execute UI update on async thread.

Swift UITableView reloadData in a closure

7 Answers7

Linked