MySQL syntax error says "near '1'" but I don't have a '1' in my query

Question

I'm making a website for the first time using PHP with a MySQL database and getting a syntax error that I don't understand. I just want to delete everything from tblreparation with a certain ID and also everything from rblrepstat with that same ID. I am using this code:

<?php
    $con=mysqli_connect("localhost","root","MYPASS","repair");
    $ID = $_REQUEST['ID'];
    $sql = mysqli_query($con, "DELETE FROM tblreparation WHERE ID = {$ID}");
    if (!mysqli_query($con,$sql)) {
      die('Error: ' . mysqli_error($con));
    }
    $sql = mysqli_query($con, "DELETE FROM tblrepstat WHERE repID = {$ID}");
    if (!mysqli_query($con,$sql)) {
      die('Error2: ' . mysqli_error($con));
    }
    echo "1 record deleted";
    mysqli_close($con); 
?>

And this is the error I am getting:

Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '1' at line 1

Near 1? I don't even see a '1'...

`{$ID}` remove `{}` and `$ID = intval($_REQUEST['ID']);` if it is an integer. — Cheery, Oct 20 '14 at 17:01
@Cheery: `{$foo}` is perfectly valid PHP. That's not the problem. — Marc B, Oct 20 '14 at 17:04
@ivancoene show the result of `echo "DELETE FROM tblreparation WHERE ID = $ID";` ... `That's not the problem` but not necessary here. — Cheery, Oct 20 '14 at 17:05
@Cheery DELETE FROM tblreparation WHERE ID = 27 it seems normal... — ivancoene, Oct 20 '14 at 17:06
@ivancoene: Does that particular query produce the error? Or is there a different value of `$ID` which produces the error? — David, Oct 20 '14 at 17:07
@David it's the query i guess.. i tried it with different ID's but ist always the same.. — ivancoene, Oct 20 '14 at 17:09
@ivancoene did try to retype it? may be you have some unicode unprintable characters there. The query is ok. And did you try to use `intval`? — Cheery, Oct 20 '14 at 17:10

vitorsdcs · Accepted Answer · 2014-10-20T17:26:00.643

You're calling mysqli_query twice for each query.

The second time you call it you're actually passing a resource as the query parameter, which causes the error you're getting.

Try changing your code to this:

<?php
    $con=mysqli_connect("localhost","root","MYPASS","repair");
    $ID = $_REQUEST['ID'];
    $sql = "DELETE FROM tblreparation WHERE ID = {$ID}";
    if (!mysqli_query($con,$sql)) {
      die('Error: ' . mysqli_error($con));
    }
    $sql = "DELETE FROM tblrepstat WHERE repID = {$ID}";
    if (!mysqli_query($con,$sql)) {
      die('Error2: ' . mysqli_error($con));
    }
    echo "1 record deleted";
    mysqli_close($con); 
?>

score -1 · Answer 2 · answered Oct 20 '14 at 17:03

-1

Your $ID might contain 1. Which also the location of the error in the query.

DELETE FROM tblreparation WHERE ID = $ID

Or if ID is containing a string or stored in another format which is string related (varchar) then wrap it in quotes:

DELETE FROM tblreparation WHERE ID = '$ID'

answered Oct 20 '14 at 17:03

Daryl Gill

5,464
9
36
69

@ivancoene Can you update your question to show the contents and var_dump of `$_REQUEST['ID'];` – Daryl Gill Oct 20 '14 at 17:12

MySQL syntax error says "near '1'" but I don't have a '1' in my query

2 Answers2