setResult does not work when BACK button pressed

Question

I am trying to setResult after the BACK button was pressed. I call in onDestroy

Intent data = new Intent();
setResult(RESULT_OK, data)

But when it comes to

onActivityResult(int requestCode, int resultCode, Intent data)

the resultCode is 0 (RESULT_CANCELED) and data is 'null'.

So, how can I pass result from activity terminated by BACK button?

score 169 · Answer 1 · edited Jul 17 '20 at 14:52

169

You need to overide the onBackPressed() method and set the result before the call to superclass, i.e

@Override
public void onBackPressed() {
    Bundle bundle = new Bundle();
    bundle.putString(FIELD_A, mA.getText().toString());
    
    Intent mIntent = new Intent();
    mIntent.putExtras(bundle);
    setResult(RESULT_OK, mIntent);
    super.onBackPressed();
}

edited Jul 17 '20 at 14:52

Bruno Bieri

9,724
11
63
92

answered Jun 02 '11 at 09:21

n224576

1,766
2
10
3

23

Do note that if you use this approach the super.onBackPressed() invocation must happen after the call to setResult() as shown above or you will have the original problem all over again! – jengelsma May 24 '12 at 18:28
1

That's best answer here. If we override onPause() or onDestroy(), onBackPressed() will be called first and it will set result to 0. Please be aware of that! – Marek Jul 05 '13 at 05:02
or you can set the default result in onCreate. Any place before finish() is fine. – Helin Wang Sep 26 '13 at 15:35
6

I implemented similar approach but it still not working. FOr instance I have the request code and the intent working but the resultCode is always 0. – Neon Warge Apr 30 '15 at 14:35
it is Dec,2020 And still it works! thanks – Dharmishtha Dec 19 '20 at 08:32

score 74 · Answer 2 · edited May 23 '17 at 11:54

74

Activity result must be set before finish() is called. Clicking BACK actually calls finish() on your activity, so you can use the following snippet:

@Override
public void finish() {
    Intent data = new Intent();
    setResult(RESULT_OK, data); 

    super.finish();
}

If you call NavUtils.navigateUpFromSameTask(); in onOptionsItemSelected(), finish() is called, but you will get the wrong result code. So you have to call finish() not navigateUpFromSameTask in onOptionsItemSelected(). wrong requestCode in onActivityResult

edited May 23 '17 at 11:54

Community

1
1

answered Mar 09 '11 at 12:18

JBM

2,930
2
24
28

This works in the OPs case, but not in general, right? There are more methods than finish() that induce the end of the app lifecycle (via onPause() and onDestroy())? Also see my comment at the other answer. – pjv Mar 16 '11 at 22:24
And even if there weren't, you wouldn't know about it when it would be introduced in an API update. Not as easily as you would when behavior of onPause() or onDestroy() changed. Those are the methods you are *supposed* to override. – pjv Mar 16 '11 at 22:31
6

@pjv - I don't get your point, what `finish` has to do with `onPause` and `onDestroy`? Those are totally not related except for that `finish` starts the termination process which `onPause` and `onDestroy` are part of. – JBM Aug 30 '11 at 19:45
1

This is the only solution that works now afaik on minSdk 26 / targetSdk 32 overriding `onBackPressed` doesn't seem to work anymore. – avalerio Jun 30 '22 at 17:38

score 21 · Answer 3 · edited Mar 27 '17 at 11:04

21

If you want to set some custom RESULT_CODE in onBackPressed event then you need to first set the result and then call the super.onBackPressed() and you will receive the same RESULT_CODE in the caller activity's onActivityResult method

    @Override
    public void onBackPressed()
    {
         setResult(SOME_INTEGER);
         super.onBackPressed();
    }

edited Mar 27 '17 at 11:04

Nuri Tasdemir

9,720
3
42
67

answered Mar 04 '14 at 13:36

Khurram Shehzad

1,010
12
16

score 11 · Accepted Answer · edited Mar 27 '17 at 11:45

11

I refactored my code. Initially I prepared some data and set it as activity result in onDestroy (this did not work). Now I set activity data each time the data to be returned is updated, and have nothing in onDestroy.

edited Mar 27 '17 at 11:45

Kapil Rajput

11,429
9
50
65

answered Apr 22 '10 at 03:03

alex2k8

42,496
57
170
221

This does not work for me since my data is update in "onPause" – Bostone Jul 22 '12 at 17:49
1

If your activity gets recreated after you call `setResult()`, your data will be lost. – Jarett Millard May 12 '16 at 13:40

score 4 · Answer 5 · answered Dec 06 '12 at 11:52

You should override onOptionsItemSelected like this:

@Override
public boolean onOptionsItemSelected(final MenuItem item) {
    switch (item.getItemId()) {
    case android.R.id.home:
        final Intent mIntent = new Intent();
        mIntent.putExtra("param", "value");
        setResult(RESULT_OK, mIntent);
        finish();
        return true;
    default:
        return super.onOptionsItemSelected(item);
    }
}

score 2 · Answer 6 · answered Mar 18 '11 at 13:02

2

Refer onActivityResult(int, int, Intent) doc

Solution is to check the resultCode for value Activity.RESULT_CENCELED. If yes, then it means that either BACK was pressed or the activity crashed. Hope it works for you guys, works for me :).

answered Mar 18 '11 at 13:02

Ankur

37
1

This is the exact solution.. You have to Result Code.. No one can set the result other than you in the code. So , if result is not OK means either its back presses Or Crashed.. – John Sep 15 '15 at 14:16

score 0 · Answer 7 · answered Jul 22 '12 at 17:57

Don't rely on any logic executed in onPause of one activity when you return to the initial one. According to the docs:

Implementations of this method (onPause) must be very quick because the next activity will not be resumed until this method returns

See http://goo.gl/8S2Y for details.

The safest way is to set result after each result altering operation is complete (as you mention in your answer)

score 0 · Answer 8 · answered Apr 15 '13 at 16:18

i paste the answer may be will be helpful to other people: when a set launcheMode with android:launchMode="singleTask" i also cant get the result, the doc says:

     /* <p>Note that this method should only be used with Intent protocols
 * that are defined to return a result.  In other protocols (such as
 * {@link Intent#ACTION_MAIN} or {@link Intent#ACTION_VIEW}), you may
 * not get the result when you expect.  For example, if the activity you
 * are launching uses the singleTask launch mode, it will not run in your
 * task and thus you will immediately receive a cancel result.
 */

and:

     /* <p>As a special case, if you call startActivityForResult() with a requestCode 
 * >= 0 during the initial onCreate(Bundle savedInstanceState)/onResume() of your
 * activity, then your window will not be displayed until a result is 
 * returned back from the started activity.  This is to avoid visible 
 * flickering when redirecting to another activity. 
 */

score 0 · Answer 9 · answered Apr 21 '10 at 00:09

0

onDestroy is too late in the chain — instead override onPause and check isFinishing() to check if your activity is at the end of its lifecycle.

answered Apr 21 '10 at 00:09

Roman Nurik

29,665
7
84
82

1

Nope, this is too late as well. – alex2k8 Apr 22 '10 at 03:01
I actually call this a bug: http://code.google.com/p/android/issues/detail?id=1671. In complex applications I think due to this there is just some behavior you can't program. – pjv Mar 16 '11 at 22:21
It is also very counterintuitive. So much that I keep making the same mistake, over a period of 2 years now already. – pjv Mar 16 '11 at 22:28
Actually - this is even worse. And it exists in JB as I'm coding. If I call setResult from onPause it is executed but nether resultCode nor data is set when onActivityReturn is executed. Why? – Bostone Jul 22 '12 at 17:49
And that's why: "Implementations of this method (onPause) must be very quick because the next activity will not be resumed until this method returns" http://goo.gl/8S2Y – Bostone Jul 22 '12 at 17:52

score 0 · Answer 10 · edited May 23 '17 at 11:54

0

Try overriding onBackPressed (from android level 5 up), or override onKeyDown() and catch KeyEvent.BUTTON_BACK (see Android Activity Results) This does the trick for me.

edited May 23 '17 at 11:54

Community

1
1

answered May 19 '11 at 08:13

MrJre

7,082
7
53
66

setResult does not work when BACK button pressed

10 Answers10

Linked

Related