Java String split Issue

Question

String url="http://someexample.com/?cid=cid123 &club_id=club123&s4c=10&dom=someexample.com&hash=testhash";
String[] params = url.split("&");  
for (String param : params)  {  
    String name = param.split("=")[0];  
    String value = param.split("=")[1];  
    System.out.println(name+":"+value);
}

It displays Output

http://someexample.com/?cid:cid123
club_id:club123
s4c:10
dom:someexample.com
hash:testhash

But I want to get cid as well so I tried the following

    String delimeter1="?";
    String delimeter2="&";
    url=url.replace(delimeter1, delimeter2);

And when I ran the program it gave me following error

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 1

Please suggest me what I am doing wrong here ?

Have you checked http://stackoverflow.com/questions/13592236/parse-the-uri-string-into-name-value-collection-in-java — fernandohur, Nov 12 '14 at 16:29

score 0 · Accepted Answer · answered Nov 12 '14 at 16:28

0

By replacing ? with &, the first part of the URL (http://someexample.com/) becomes a param too. Splitting this one with the = will only return 1 part, as it does not contain any equal sign. And then, accessing [1] of it will fail.

I would suggest to only split a param if it contains an equal sign:

if (param.contains("=") { ... }

answered Nov 12 '14 at 16:28

cello

5,356
3
23
28

thanks for finding out but how can I solve this out then? Any idea. – Madan Madan Nov 12 '14 at 16:29

score 0 · Answer 2 · answered Nov 12 '14 at 16:31

I suggest you to change the url String and get only the part of the String after ?.

String url="http://someexample.com/?cid=cid123 &club_id=club123&s4c=10&dom=someexample.com&hash=testhash";
url = url.substring(url.indexOf('?')+1);
String[] params = url.split("&");  
for (String param : params)  {  
    String name = param.split("=")[0];  
    String value = param.split("=")[1];  
    System.out.println(name+":"+value);
}

score 0 · Answer 3 · answered Nov 12 '14 at 16:35

Use URL class to help with parsing. Also, code defensively for when there is not "cid" in the query:

URL url = new URL("http://someexample.com/?"
    + "cid=cid123&club_id=club123&s4c=10&"
    + "dom=someexample.com&hash=testhash");
System.out.println(url.getQuery());
String[] params = url.getQuery().split("&");

for (String param : params) {
  String[] pair = param.split("=");
  if (pair.length == 2 && pair[0].equals("cid")) {
    String value = pair[1];
    System.out.printf("cid is %s", value);
  }
}

Java String split Issue

3 Answers3