Data is not being inserted in mysql database through php script

Question

Inserting data to mysql database through php.

<?php

    session_start();

    $username1=$_GET['uname'];
    $pwd1=$_GET['pwd'];


    mysql_connect("localhost","root","")or die("cannot connect to my sql");
    mysql_select_db("webapp")or die("cannot connect database webapp");

    // CHANGE QUERY FOR INSERT
    $sql="INSERT INTO login (uname, pwd) VALUES ('$username1', '$pwd1')";



    //$sql = "INSERT INTO login ".
         //  "(uname,pwd) ".
           //"VALUES ".
           //"('$username1','$pwd1')";


    // EXECUTE QUERY AND GET RESULT IN $RESULT
    $result=mysql_query($sql);

    //THIS TIME WE ARE NOT CHECKING $COUNT
    if($result)
    {
    echo "You have successfully Inserted your new record";
    }
    else
    {
    echo "Operation Failure please re-attempt";
    }

?>

When i execute this script it is not inserting the values to the database.. Database view in XAMPP

It is generally bad practice to provide username/password fields via GET method, because they are visible in the URL bar. Use POST instead (it's not encrypted, but at least it's not visible in the URL) — user2435860, Dec 03 '14 at 23:57
what @AlienWebguy is trying to say is to use `PDO` with prepared statements instead of `mysql_*` functions. http://stackoverflow.com/questions/1457131/php-pdo-prepared-statements — Victory, Dec 04 '14 at 00:18

score 0 · Answer 1 · edited May 23 '17 at 11:57

Your code seems perfectly able to function as you have intended. Other users have mentioned that it would be better practise to use POST instead of GET. I would also add that you should sanitise those inputs.

I have replicated your code on my own server. It works fine. I would therefore recommend to you to revisit the fact you are not using a password for your root user (Connecting to mysql in xampp without password). I would double check that the reference table names and fields are correct. I would double check permissions to write to the database and possibly print out php errors to the page....

error_reporting(E_ALL);  ini_set('display_errors', 1);

Finally, turn on mysql logging if not already on: http://www.pontikis.net/blog/how-and-when-to-enable-mysql-logs

check your web server log (depends on your set-up) and server log to see if any errors are being outputted to the logs. Your code should work.

And also just print out your query string to see if it is coming out as expected:

print($sql); exit;

I wonder if you are getting anything printed to screen or if you are actually getting "You have successfully Inserted your new record". Of course that would be the first port of call that something is wrong. Perhaps $result is always true/contains resource data no matter if insertion to mysql worked or not. I would also therefore print out the result resource array to see what was actually returned.

Data is not being inserted in mysql database through php script

1 Answers1