MySQL Edit records using PHP

Question

I am not able to edit the field and update it. The name field displays the text":

Notice: Undefined variable: row in D:\XAMPP\htdocs\test\test5.php on line 31

instead of the value. Might have done some silly code error, I'm a naivete.

<!DOCTYPE html>
<html>
<body>
<?php
define('DB_NAME', 'test');
define('DB_USER', '');
define("DB_PASSWORD", '');
define('DB_HOST', 'localhost');

$link = mysql_connect(DB_HOST, DB_USER, DB_PASSWORD);
$db_selected = mysql_select_db(DB_NAME, $link);

if(isset($_GET['del']))
{
    $value1=$_GET['del']; 
    $rs = mysql_query("SELECT * from `add` where empid ='".$value1."'"); 
    $row = mysql_fetch_array($rs);
}
?>
    <form action="test7.php" method="post">
        <ul>
            <li>
                Name:</br>
                <input type="text" name="name" value="<?php echo $row[0]; ?>">
            </li>
            <li>
                <input type="submit" value="UPDATE">
            </li>
        </ul>
    </form>
</body>
</html>

Your `$row` variable is not set if you don't have a `del` GET parameter. That is why you get an error when you try to read that variable on **line 31** with `` — AeroX, Dec 23 '14 at 15:55

score 3 · Accepted Answer · answered Dec 23 '14 at 15:56

3

You can check, is the $row[0]is exists. If there are no del parameter in the $_GET then $row will not exists, becuase you are creating $row in the condition.

<input type="text" name="name" value="<?php echo (isset($row[0]) ? $row[0] : ''); ?>">

NOTE

Do not use mysql functions. They are deprecated. Use mysqli or PDO instead.
Avoid sql injection by escaping your variables from outside, or use prepared statements.

answered Dec 23 '14 at 15:56

vaso123

12,347
4
34
64

Now getting a blank field – user645 Dec 23 '14 at 17:32
How can i chck wether $row[0] exists? – user645 Dec 23 '14 at 17:47
As you can see in my code, I am calling the `isset()` function. That syntax, what I've used, a shorter version of `if (isset($row[0])) { echo $row[0]; } else { echo ''; }` – vaso123 Dec 24 '14 at 10:20

score 1 · Answer 2 · answered Dec 23 '14 at 15:55

1

You are echo'ing $row[0] in your form without declaring it. You need to initialize and declare $row outside the if statement and before you echo it.

answered Dec 23 '14 at 15:55

Kevin

874
3
16
34

How can i chck wether $row[0] exists? – user645 Dec 23 '14 at 17:48
@user645 `` – Kevin Dec 24 '14 at 08:03

geekido · Answer 3 · 2014-12-23T16:00:31.237

0

updated code.

<?php

$row = "";
 if(isset($_GET['del']))
    {
     $value1=$_GET['del']; 
     $rs = mysql_query("SELECT * from `add` where empid ='".$value1."'"); 
     $row = mysql_fetch_array($rs);
    }
?>

<form action="test7.php" method="get">
    <ul>
        <li>
            Name:</br>
            <input type="text" name="name" value="<?php echo $row[0]; ?>">
        </li>

        <li>
            <input type="submit" value="UPDATE">
        </li>
    </ul>
</form>

you must declare $row first. if you declare it in if, you can't use it outside. Also change your form method to GET

edited Dec 23 '14 at 16:00

answered Dec 23 '14 at 15:54

geekido

171
5

I've copied your code and change two sections. Would you please share your code using pastebin or something – geekido Dec 23 '14 at 18:58

MySQL Edit records using PHP

3 Answers3