Adding a node to double list

Question

I want to add a Newnode to the end of a list but it crashes and goes into a endless loop. I am attaching the function: hope to your help!!

    void AddProduct(products **head,products *newProduct)
{
    products* current=*head;
    if(current == NULL)
     {
        (*head) =(products *)malloc(1*sizeof(products));
        (*head) = newProduct;
         current=*head;
        return;
     }
    while(current->nextProduct!=NULL)
    {
        current=current->nextProduct;
    }
    //Attaching the new product to the list
    current->nextProduct=newProduct;
    newProduct->prevous=current;
    //SortList(head);
    }

`(*head) = newProduct;` - tell me in your own words what this does — user253751, Jan 23 '15 at 08:56
That malloc() is totally unnecessary, as you're overwriting that pointer anyway. Please also show the code that you're using to initialize and populate the list (i.e. the code that calls this function). — SukkoPera, Jan 23 '15 at 08:59
[In C you should not cast the return of `malloc`.](http://stackoverflow.com/questions/605845/do-i-cast-the-result-of-malloc) — Some programmer dude, Jan 23 '15 at 09:06

score 0 · Answer 1 · answered Jan 23 '15 at 08:56

When creating a new element, you're both accepting it as an argument, and allocating it yourself inside the function. You're overwriting the newly allocated pointer with the one passed in, it doesn't make any sense.

Also, you're not setting the nextProduct field of the new element.

Finally, you're using too many casts and parentheses.

Adding a node to double list

1 Answers1