How to load a image from a URL into a viewpager

Question

i've searched the internet for this question and i couldn't find anything good. I did look on the Android Developer Site but they load a image from a URL into a ImageView.

Here is my code:

Openfactsscreen activity :

public class Openfactsscreen extends Activity {




    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_openfactsscreen); 

        ViewPager viewPager = (ViewPager) findViewById(R.id.view_pager);
        ImageAdapter adapter = new ImageAdapter(this);
        viewPager.setAdapter(adapter);
        }

        public void openmenu(View view){
        Intent intent = new Intent(this, SendFact.class);
        startActivity(intent); }



    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.openfactsscreen, menu);
        return true;
 }

}

ImageAdapter.java:

public class ImageAdapter extends PagerAdapter {

        Context context;
        private int[] GalImages = new int[] {
        R.drawable.factcard2,
        R.drawable.factcard8,
        R.drawable.factcard4
        };



        ImageAdapter(Context context){
        this.context=context;
        }
        @Override
        public int getCount() {
        return GalImages.length;
        }

        @Override
        public boolean isViewFromObject(View view, Object object) {
        return view == ((ImageView) object);
        }

        @Override
        public Object instantiateItem(ViewGroup container, int position) {
        ImageView imageView = new ImageView(context);
        int padding = context.getResources().getDimensionPixelSize(R.dimen.padding_medium);
        imageView.setPadding(padding, padding, padding, padding);
        imageView.setScaleType(ImageView.ScaleType.CENTER_INSIDE);
        imageView.setImageResource(GalImages[position]);
        ((ViewPager) container).addView(imageView, 0);
        return imageView;
        }

        @Override
        public void destroyItem(ViewGroup container, int position, Object object) {
        ((ViewPager) container).removeView((ImageView) object);
        }


}

activity_openfactsscreen :

    <RelativeLayout    xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="fill_parent"
    android:layout_height="fill_parent"
    android:background="@drawable/backgroundotheractivities" >

    <android.support.v4.view.ViewPager
        android:id="@+id/view_pager"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:layout_below="@+id/imageView1" />

    <ImageView
        android:id="@+id/imageView1"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_alignParentTop="true"
        android:layout_centerHorizontal="true"
        android:src="@drawable/factsscreen_layout" />

    <ImageButton
        android:id="@+id/imageButton1"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_alignParentLeft="true"
        android:layout_alignParentTop="true"
        android:layout_marginLeft="23dp"
        android:layout_marginTop="18dp"
        android:background="@drawable/emailbutton"
        android:onClick="openmenu" />

    <ImageButton
        android:id="@+id/imageButton2"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_alignTop="@+id/imageButton1"
        android:layout_toRightOf="@+id/imageButton1"
        android:background="@drawable/informationbutton" />

</RelativeLayout>

Everything works fine, if anyone knows a good site to look on or if anyone wants to help me that would be great!

Anyway thanks for your time and have nice day!

I don't have them, i don't know how i should start. – DyRight Feb 03 '15 at 09:50 — DyRight, Feb 03 '15 at 09:50
what do mean by you don't have them? – Muthu Feb 03 '15 at 09:52 — Muthu, Feb 03 '15 at 09:52
I do have the links ready but i don't have the code for it. – DyRight Feb 03 '15 at 10:04 — DyRight, Feb 03 '15 at 10:04

Muthu · Accepted Answer · 2015-02-03T11:04:13.510

6

Add this at end of your Class `

public class ImageAdapter extends PagerAdapter {

        Context context;
        private int[] GalImages = new int[] {
        R.drawable.factcard2,
        R.drawable.factcard8,
        R.drawable.factcard4
        };



        ImageAdapter(Context context){
        this.context=context;
        }
        @Override
        public int getCount() {
        return GalImages.length;
        }

        @Override
        public boolean isViewFromObject(View view, Object object) {
        return view == ((ImageView) object);
        }

        @Override
        public Object instantiateItem(ViewGroup container, int position) {
        ImageView imageView = new ImageView(context);
        int padding = context.getResources().getDimensionPixelSize(R.dimen.padding_medium);
        imageView.setPadding(padding, padding, padding, padding);
        imageView.setScaleType(ImageView.ScaleType.CENTER_INSIDE);
        //imageView.setImageResource(GalImages[position]);

        new LoadImage(imageView).execute("Your URL");

        ((ViewPager) container).addView(imageView, 0);
        return imageView;
        }

        @Override
        public void destroyItem(ViewGroup container, int position, Object object) {
        ((ViewPager) container).removeView((ImageView) object);
        }



     private class LoadImage extends AsyncTask<String, String, Bitmap> {
            ImageView img=null;
            public LoadImage(ImageView img){
                this.img=img;
            }
            @Override
            protected void onPreExecute() {
                super.onPreExecute();

            }
            protected Bitmap doInBackground(String... args) {
                Bitmap bitmap=null;
                try {
                    bitmap = BitmapFactory.decodeStream((InputStream)new URL(args[0]).getContent());
                } catch (Exception e) {
                    e.printStackTrace();
                }
                return bitmap;
            }
            protected void onPostExecute(Bitmap image) {
                if(image != null){
                    img.setImageBitmap(image);
                }
            }
        }`
     }

edited Feb 03 '15 at 11:04

answered Feb 03 '15 at 10:13

Muthu

1,022
1
7
17

Thanks for your time! When i change imageview.setImageResource line and add yours it gives me this error : The method execute(String...) in the type AsyncTask is not applicable for the arguments – DyRight Feb 03 '15 at 10:38
GalImages[position] returns String url format is in it? – Muthu Feb 03 '15 at 10:43
No i just changed the line with yours – DyRight Feb 03 '15 at 10:47
Replace GalImages[position] with url you want! – Muthu Feb 03 '15 at 10:51
it should be new LoadImage(imageView).execute("Your Url"); – Muthu Feb 03 '15 at 10:53
I just did but eclipse keeps giving me errors, "insert ; and insert ) to complete" But even if do that the errors keep coming .? – DyRight Feb 03 '15 at 10:55
you should add class out side of your class – Muthu Feb 03 '15 at 10:56
can you move this inside the class? and try it! – Muthu Feb 03 '15 at 10:58
Thank you! It works great! I really appreciate it! But i have 1 one more question left, when i add multiple links to the code (because that's my goal, using the swipe to show images) it will show the images from the url like a diashow. It changes every 2 seconds – DyRight Feb 03 '15 at 11:55
yes you cant get image from UI thread it has to be set in separate thread. if my answer fixes your issue mark it as accepted answer. :) – Muthu Feb 03 '15 at 12:02
Hi, is there any way i could contact you? – DyRight Feb 04 '15 at 19:11
I want to learn some things, and you seem like the perfect teacher. Well ofcourse only if you have time – DyRight Feb 04 '15 at 19:31

score 0 · Answer 2 · edited May 23 '17 at 12:13

0

You can try this simple code :

    URL url = new URL("yourURL");
Bitmap bmp = BitmapFactory.decodeStream(url.openConnection().getInputStream());
imageView.setImageBitmap(bmp);

Otherwise you can look this answer

Also you can try this :

 try {
  ImageView i = (ImageView)findViewById(R.id.image);
  Bitmap bitmap = BitmapFactory.decodeStream((InputStream)new URL(URL).getContent());
  i.setImageBitmap(bitmap); 
} catch (MalformedURLException e) {
  e.printStackTrace();
} catch (IOException e) {
  e.printStackTrace();
}

edited May 23 '17 at 12:13

Community

1
1

answered Feb 03 '15 at 09:51

Skizo-ozᴉʞS ツ

19,464
18
81
148

It gives me a error at : Syntax error on token "bmp", VariableDeclaratorId expected after this token, and Syntax error on token(s), misplaced construct(s) – DyRight Feb 03 '15 at 10:02
Try `public static Bitmap bmp` or just `public BitMap bmp` – Skizo-ozᴉʞS ツ Feb 03 '15 at 10:05
Thanks for your time, It still gives me a error, it says i have to add "}" but when i do that it doesn't change anything – DyRight Feb 03 '15 at 10:40
Did you try my two answers? Did you see the post of the link? – Skizo-ozᴉʞS ツ Feb 03 '15 at 10:43
Yes i looked at it and i tried both of your answers – DyRight Feb 03 '15 at 10:48

How to load a image from a URL into a viewpager

2 Answers2