Calling a function with a dynamic parameter

Question

I have this code:

while($row=mysql_fetch_array($query)){
  echo '<a onclick="return myFunction('.$row['value']'.')"></a>';
}

I need to use that dynamic parameter in a function like this:

function myFunction(my_value){
 alert('This is my value' + my_value);
 return true;
}

But the function is not called because of that parameter.Does anyone why?

in the parameter, is that an integer? or a string? quote it :) — Kevin, Feb 04 '15 at 08:23
@Ghost , it's a string , actually it's more like a directory path: doc/docx/doc.txt — Petru Lebada, Feb 04 '15 at 08:24
make sure function comes before it's used. Also, what Ghost said, add quotes — Forien, Feb 04 '15 at 08:24
Check the HTML/JS that's being output. It has syntax errors. Read the duplicate for good ways to deal with this problem. — deceze, Feb 04 '15 at 08:29

score 1 · Accepted Answer · answered Feb 04 '15 at 08:25

1

You have a syntax error, it should be this:

echo '<a onclick="return myFunction('.$row['value'].')"></a>';

Also if your value is a string value you need to use quotes:

echo '<a onclick="return myFunction(\''.addslashes($row['value']).'\')"></a>';

answered Feb 04 '15 at 08:25

Bart Haalstra

actually the syntax error was just here,i forgot to add that quote , but i didnt knew the second one.I'll give it a try – Petru Lebada Feb 04 '15 at 08:27
yes,that was the problem,thank you! – Petru Lebada Feb 04 '15 at 08:30

1 Answers1