angularJS: window.alert only after method is done

Question

In my controller with the help of service i'm sending some qr-data to users so:

    $scope.sendtoList = function () {
        $scope.qrStatus = false;
        angular.forEach($scope.users, function (item) {        
          if (item.Selected){
            inviteService.sendQR(item.Emails.main, $scope.company.Id).then(function(response) {
              $scope.qrStatus = true;              
            },
            function(err) {
              $scope.qrStatus = false;              
            });
          }
        });
        if ($scope.qrStatus){
          $window.alert('QR-code has been sended successfully.');
        }
        else{
          $window.alert('Warning! QR-code has not been sended successfully.');
        }
      }

and i see some strange behaviour: it always show warning alert, even if method is done succesfully - i think it is of promisses. But how could i show window in my case only after servise promisse is returned?

You need to treat this in a non-blocking manner, rather than a blocking manner. Your promises are returning way after your code has completed. — Brian Noah, Feb 13 '15 at 07:12
done. Not tested, but something around what I posted should work. — Brian Noah, Feb 13 '15 at 07:26

score 0 · Answer 1 · edited May 23 '17 at 11:58

0

Hope one of the following helps

1) Try looking at the following post: $success call back function from AngularJS

Its a similar question and the following js fiddle might help: http://jsfiddle.net/E5HGy/6/

2) A counter as stated above would also solve the problem, something such as

if(i == selector.length) 
    // "callback"

would essientially solve it

edited May 23 '17 at 11:58

Community

1
1

answered Feb 13 '15 at 07:18

John

1,677
4
15
26

score 0 · Accepted Answer · answered Feb 13 '15 at 07:26

In order to do this with promises, you need to create a counter that checks every time a user is updated, and then triggers the alert once all are accounted for.

$scope.sendQRtoList = function () {
    $scope.qrStatus = false;
    var count = 0;
    var length = $scope.users.length;
    var error = 0;
    angular.forEach($scope.users, function (item) {
        if (item.Selected){
            inviteService
                .sendQR(item.Emails.main, $scope.company.Id)
                .then(function(response) {
                    //yay!  
                },
                function(err) {
                    error++;
                })
                .finally(function () {
                    count++;
                    if (count === length && error === 0) {
                        $window.alert('QR-code has been sent successfully.');
                    }
                    if (count === length && error !== 0) {
                        $window.alert('Warning! QR-code has not been sent successfully.')
                    }
                });
        }
    });
};

.finally() happens on every promise, that's where you want to add your counter incrementation.

angularJS: window.alert only after method is done

2 Answers2