IOS 8 iPad App Crashes When UIActivityViewController Is Called

Question

When a UIActivityViewController is called on the iPhone in this app, it works perfectly, but when called on a iPad, the app crashes. Below is the code I used:

func shareButtonPress() {

    //when the share button is pressed, default share phrase is added, cropped image of highscore is added

    var sharingItems = [AnyObject]()

    var shareButtonHighscore = NSUserDefaults.standardUserDefaults().objectForKey("highscore") as Int!

    sharingItems.append("Just hit \(shareButtonHighscore)! Beat it! #Swath")

    UIGraphicsBeginImageContextWithOptions(UIScreen.mainScreen().bounds.size, false, 0);
    self.view.drawViewHierarchyInRect(view.bounds, afterScreenUpdates: true)
    var image:UIImage = UIGraphicsGetImageFromCurrentImageContext();

    UIGraphicsEndImageContext();

    sharingItems.append(image)

    let activityViewController = UIActivityViewController(activityItems: sharingItems, applicationActivities: nil)

    var barButtonItem: UIBarButtonItem! = UIBarButtonItem()

    activityViewController.excludedActivityTypes = [UIActivityTypeCopyToPasteboard,UIActivityTypeAirDrop,UIActivityTypeAddToReadingList,UIActivityTypeAssignToContact,UIActivityTypePostToTencentWeibo,UIActivityTypePostToVimeo,UIActivityTypePrint,UIActivityTypeSaveToCameraRoll,UIActivityTypePostToWeibo]

    self.presentViewController(activityViewController, animated: true, completion: nil)

}

As you can see, I'm programming in Swift, in the SpriteKit Framework, and I don't understand why the app is crashing.

I'm receiving this error:

Terminating app due to uncaught exception 'NSGenericException', reason: 'UIPopoverPresentationController (<_UIAlertControllerActionSheetRegularPresentationController: 0x7fc7a874bd90>) should have a non-nil sourceView or barButtonItem set before the presentation occurs.'

What can I do to fix this problem?

> What can I do to fix this problem? -- 1. read the error message. 2. check docs on `UIPopoverController` — Mundi, Feb 16 '15 at 19:50

tdh · Accepted Answer · 2015-02-18T15:39:38.640

31

Before presenting the UIActivityViewController, add in this line of code:

activityViewController.popoverPresentationController?.sourceView = self.view

This way, the view controller knows in which frame of the GameViewController to appear in.

edited Feb 18 '15 at 15:39

answered Feb 18 '15 at 03:46

tdh

884
1
11
22

score 4 · Answer 2 · answered Feb 17 '15 at 14:02

4

If you read the error it says how to fix it, you need to set the barButtonItem or sourceView from which to present the popover from, in your case:

func shareButtonPress(pressedButton: UIBarButtonItem) { 

    ...

    activityViewController.popoverPresentationController.barButtonItem = pressedButton

    self.presentViewController(activityViewController, animated: true, completion: nil)
}

answered Feb 17 '15 at 14:02

Steve

2,526
2
20
30

Now I'm getting this error: `[MyGame.GameViewController shareButtonPress]: unrecognized selector sent to instance 0x15f8c610'` – tdh Feb 17 '15 at 19:02
What can I do to correct this? I can't replace UIBarButtonItem with the name of the actual button, because the actual button is defined in GameScene. – tdh Feb 17 '15 at 19:04
How do you add the target to the UIBarButtonItem? – Steve Feb 18 '15 at 12:37
This is a much better solution than others, because this view controller should be shown at top of "caller" view. – artem Jun 20 '20 at 19:02

score 2 · Answer 3 · answered Jan 31 '20 at 07:23

Swift 5:

Check if the device is iPhone or iPad and based on that add a sourceView and present the activityController

let activity = UIActivityViewController(activityItems: [self], applicationActivities: nil)
if UIDevice.current.userInterfaceIdiom == .phone {
    UIApplication.topViewController?.present(activity, animated: true, completion: nil)
} else {
    activity.popoverPresentationController?.sourceView = UIApplication.topViewController!.view
    UIApplication.topViewController?.present(activity, animated: true, completion: nil)
}

score 1 · Answer 4 · answered Sep 06 '15 at 21:59

There are two option, the action came from a UIBarButtonitem or UIButton that is a UIView.

func shareButtonPress() {

    ...

    if let actv = activityViewController.popoverPresentationController {
        actv.barButtonItem = someBarButton // if it is a UIBarButtonItem

        // Or if it is a view you can get the view rect
        actv.sourceView = someView
        // actv.sourceRect = someView.frame // you can also specify the CGRect
    }

    self.presentViewController(activityViewController, animated: true, completion: nil)
}

You may have to add a sender to your function like func shareButtonPress(sender: UIBarButtonItem) or func shareButtonPress(sender: UIButton)

score 1 · Answer 5 · edited Apr 27 '17 at 11:55

1

I added for Swift 3:

activityViewController.popoverPresentationController?.sourceView = self.view

fixed my issue.

edited Apr 27 '17 at 11:55

Whirlwind

14,286
11
68
157

answered Apr 27 '17 at 11:41

Anas

335
5
7

IOS 8 iPad App Crashes When UIActivityViewController Is Called

5 Answers5

Linked

Related