Javascript / JQuery Conflict

Question

I am a newbie to this. I have two javascript / jquery on my page. If I use 1st Script, the 2nd one doesn't work. If I remove the 1st script, the 2nd one works fine. I don't know how to solve this issue. I know there is a "no conflict" script. I tried but that didn't work out. I maybe tried in wrong way. Please someone help me. How can I run both of them? I have posted both the script below:

Script Number 1:

<script type="text/javascript" src="http://ajax.googleapis.com/ajax/
libs/jquery/1.3.0/jquery.min.js"></script>
<script type="text/javascript">

$(document).ready(function(){
    $(".sign_in").click(function(){
        $("#sign_box").show();
        return false;
    });
    $("body #headerwrap").click(function(){
        $("#sign_box").hide();
        return false;
    });
});

</script>

Script Number: 2

<script language="javascript" type="text/javascript">

var fieldstocheck = new Array();
fieldnames = new Array();
function checkform() {
    for (i=0;i<fieldstocheck.length;i++) {
        if (eval("document.subscribeform.elements['"+fieldstocheck[i]+"'].value")==""){
            alert("Please enter your "+fieldnames[i]);
            eval("document.subscribeform.elements['"+fieldstocheck[i]+"'].focus()");
            return false;
        }
    }
    return true;
}
function addFieldToCheck(value,name) {
    fieldstocheck[fieldstocheck.length] = value;
    fieldnames[fieldnames.length] = name;
}
</script>

just a note, you are using a very old version of jQuery. check [here](https://code.jquery.com/jquery/) for all available versions — dippas, Feb 20 '15 at 17:51
Yes... Show this error: Uncaught ReferenceError: $ is not defined — Ron, Feb 20 '15 at 17:52
You don't need to use `jQuery.noConflict` because you are just using javascript, no conflict is made to use jquery with other js libraries that also use the `$` sign — Yerko Palma, Feb 20 '15 at 17:53
`$ is not defined` typically means that jQuery isn't loaded. — j08691, Feb 20 '15 at 17:55

score 1 · Answer 1 · edited May 23 '17 at 12:28

Where is second script on the page ? It would need a bit more info about it to see what's happening.

Second script looks very ominous, probably very old script. Some points of concern:

All your code is thrown at global object
fieldnames is not declared (missing var)
Declaring array with [] is prefferable to new Array() syntax
addFieldToCheck and checkform functions seems not to be used (at least not in the code you posted)
it uses eval which is considered a bad practice

For a good start try wrapping your second one in self invoking anonymous function:

(function() {
  var fieldstocheck = [],
    fieldnames = [];

  function checkform() {
    //... 
  }

}());

score 1 · Answer 2 · answered Feb 20 '15 at 19:24

1

Just a note about eval. You don't need to use eval in the way you're using it. You can simply use the bracket notation directly:

eval("document.subscribeform.elements['"+fieldstocheck[i]+"'].value")

is the same as

document.subscribeform.elements[fieldstocheck[i]].value

and

eval("document.subscribeform.elements['"+fieldstocheck[i]+"'].focus()");

is the same as

document.subscribeform.elements[fieldstocheck[i]].focus();

answered Feb 20 '15 at 19:24

Patrick Gunderson

3,263
17
28

Thanks for having nerve explaining in detail :) – NenadP Feb 20 '15 at 19:47

score 0 · Accepted Answer · answered Feb 20 '15 at 19:27

There's no conflict.

The first script has a click listeners that return false. I'm assuming the sign in button is used to submit the form.

Returning false on that click event will prevent the form from submitting which means the execution path will never enter your functions in the second script.

Consider removing the return false.

EDIT: Here's some more information on why it's generally bad practice to return false (unless you know exactly what you're doing and why)

http://firebreaksice.com/avoid-return-false-in-jquery-click-bindings/

Thank you very much for the help. I have used " e.preventDefault(); " instead of "return false;" and everything working perfectly. ... — Ron, Feb 20 '15 at 21:25

Javascript / JQuery Conflict

3 Answers3