Neither startEdit or setOnEditCommit getting called

Question

I followed this example mentioned on this link - UITableView - Better Editing through Binding? I changed it a bit accordingly

Model class - 

     public static class TableData {

        private String firstName, lastName;

        private TableData(String first, String last) {
            this.firstName = first;
            this.lastName = last;
        }

        public String getFirstName() {
            return firstName;
        }

        public void setFirstName(String firstName) {
            this.firstName = firstName;
        }

        public String getLastName() {
            return lastName;
        }

        public void setLastName(String lastName) {
            this.lastName = lastName;
        }

    }

Custom Cell factory -

     public static class TextFieldCellFactory implements Callback<TableColumn<TableData, String>, TableCell<TableData, String>> {

    @Override
    public TableCell<TableData, String> call(TableColumn<TableData, String> param) {
        TextFieldCell textFieldCell = new TextFieldCell();
        return textFieldCell;
    }

    public static class TextFieldCell extends TableCell<TableData, String> {

        private TextField textField;
        private StringProperty boundToCurrently = null;
        private String newval = "";

        public TextFieldCell() {


            textField = new TextField();
            textField.setOnKeyPressed(new EventHandler<KeyEvent>() {
                @Override
                public void handle(KeyEvent t) {
                    if (t.getCode() == KeyCode.ENTER) {
                        System.out.println("key pressed");
                        commitEdit(textField.getText());

                    } else if (t.getCode() == KeyCode.ESCAPE) {
                        cancelEdit();
                    }
                }
            });

            textField.textProperty().addListener(new ChangeListener<String>() {

                @Override
                public void changed(ObservableValue<? extends String> observable, String oldValue, String newValue) {
             // throw new UnsupportedOperationException("Not supported yet."); //To change body of generated methods, choose Tools | Templates.

                    // commitEdit(newValue);
                    System.out.println("" + newValue);
                    newval = newValue;
                }

            });

            textField.focusedProperty().addListener(new ChangeListener<Boolean>() {

                public void changed(ObservableValue<? extends Boolean> observable, Boolean oldValue, Boolean newValue) {

                        if(!newValue){
                        System.out.println("losing focus" + newval);
                        //commichange();
                        commitEdit(textField.getText());
                        }

                    }
                });



            this.setGraphic(textField);
        }

        @Override
        protected void updateItem(String item, boolean empty) {
            super.updateItem(item, empty);
            if (!empty) {
                // Show the Text Field
                this.setContentDisplay(ContentDisplay.GRAPHIC_ONLY);
                textField.setText(item);



            } else {
                this.setContentDisplay(ContentDisplay.TEXT_ONLY);
            }
        }

    }
}

setting onEditCommit-

c1.setOnEditCommit(
            new EventHandler<TableColumn.CellEditEvent<TableData, String>>() {
                @Override
                public void handle(TableColumn.CellEditEvent<TableData, String> t) {
                    System.out.println("ON edit commit" + t);
                    ((TableData) t.getTableView().getItems().get(
                            t.getTablePosition().getRow())).setFirstName(t.getNewValue());
                }
            }
    );

1. Problem 1- I want to know what happens when commitEdit() is called. Does it invoke setOnEditCommit ? If it does then why its not invoking setOnEditCoommit
2. Problem 2 - Why its not going into setOnEditCommit?
3. Problem 3 I applied startEdit just to check if its enters that field. But that method also is not getting invoked.

Can anyone specify what i am missing here.I don't want a workaround. I need to understand whats the reason behind it P.S I have removed the binding properties as given in the link.

Answer 1

Your table never enters an editing state (because you never ask it to). Because the cell never has isEditing() return true, the default commitEdit() method becomes a no-op.

You need the TableView to know that it has to start editing a cell when the text field in that cell receives focus. You can do this by modifying the focus listener on the text field:

                textField.focusedProperty().addListener(new ChangeListener<Boolean>() {
                    @Override
                    public void changed(ObservableValue<? extends Boolean> observable, Boolean oldValue, Boolean newValue) {
                        if (newValue) {
                            getTableView().edit(getIndex(), getTableColumn());
                        } else {
                            commitEdit(textField.getText());
                        }
                    }
                });