Image is partially downloading,

Question

I cannot download the file in following url: http://avisloyalty.eu/assets/fleetlarge//VW_Passat_15.jpg

Only a part of the file is being downloaded.

Following is my code. Please let me know if I'm doing anything wrong.

URLConnection urlConn = new URL( "http://avisloyalty.eu/assets/fleetlarge//VW_Passat_15.jpg").openConnection();
InputStream is = urlConn.getInputStream();
FileOutputStream fos = new FileOutputStream( file.getPath() );

byte[] buffer = new byte[4096];
int len;

while( ( len = is.read( buffer ) ) > 0 )
{
    fos.write( buffer, 0, len );
}
fos.close();

Try changing "> 0" in the while loop to != -1. It might be reading lots of zero-length arrays but hasn't actually finished yet (you get a -1 when the stream has ended). I always prefer to use something like HttpClient to do things like this (as it handles things like redirects etc), maybe look at this thread... http://stackoverflow.com/questions/10960409/how-do-i-save-a-file-downloaded-with-httpclient-into-a-specific-folder — BretC, Mar 30 '15 at 15:44
Bret thanks for the suggestion, but it didn't work. I'll check the question that you have shared thanks. mean time if you could find some thine more please let me know. Thanks a lot — Shanaka Kuruwita, Mar 30 '15 at 15:51

score 1 · Accepted Answer · answered Mar 30 '15 at 15:58

I just tried this...

    HttpClient client = HttpClientBuilder.create().build();
    HttpGet get = new HttpGet("http://avisloyalty.eu/assets/fleetlarge//VW_Passat_15.jpg");

    HttpResponse execution = client.execute(get);
    HttpEntity entity = execution.getEntity();
    FileOutputStream outputStream = new FileOutputStream("C:\\tmp\\imgout.jpg");

    if (entity != null) {
        InputStream inputStream = entity.getContent();
        IOUtils.copy(inputStream, outputStream);
    }

    outputStream.close();

...and the output file contains the TEXT...

<HTML>
<HEAD>
<TITLE>avisloyalty.eu</TITLE>
<META NAME="robots" CONTENT="noindex">
</HEAD>
<FRAMESET FRAMESPACING="0" BORDER="0" FRAMEBORDER=No ROWS="100%,*">
  <FRAME SRC="https://www.avisloyalty.eu/assets/fleetlarge//VW_Passat_15.jpg">
</FRAMESET>
<NOFRAMES>
Sorry, your browser doesn't seem to support frames! <br>
Proceed to <A href="https://www.avisloyalty.eu/assets/fleetlarge//VW_Passat_15.jpg">https://www.avisloyalty.eu/assets/fleetlarge//VW_Passat_15.jpg</A> manually.
</NOFRAMES>
</HTML>

So probably nothing wrong with your code (I'd still use != -1 instead of > 0 though)! Maybe you need to set a request header or something...

Oh I never open it. Clever you have done that. Actually I'm not sure which header to change, and how to do that. Anyway as you have suggested I'm going to use HttpClient, hope it will work. — Shanaka Kuruwita, Mar 30 '15 at 16:10
@Shan-mobile I suspect you actually want to be downloading HTTPS>>"https://www.avisloyalty.eu/assets/fleetlarge//VW_Passat_15.jpg", but when I try that, I get a load of certificate errors - you might want to look at http://stackoverflow.com/questions/1828775/how-to-handle-invalid-ssl-certificates-with-apache-httpclient — BretC, Mar 30 '15 at 16:17
Yes, exactly I was working on the same issue too. Just trying to put their certificate to ssl-keystore. Anyway thanks a lot for helping me. I hope I can manage from here. — Shanaka Kuruwita, Mar 30 '15 at 16:20

Image is partially downloading,

1 Answers1