PHP switch "||" not working properly

Question

In the switch statement, when i have a case with "||" it doesn't work properly.

$get = 'item';
switch ($get):

case 'items' || 'several-items':
    echo 'items';
    break;

case 'item':
    echo 'item';
    break;

endswitch;

This code outputs items. Is this a php bug ?

$get = 'several'; outputs items too.

So the problem is definitely with the '||' operator, because the following code works just fine:

$get = 'item';
switch ($get):

case 'items':
case 'several-items':
    echo 'items';
    break;

case 'item':
    echo 'item';
    break;

endswitch;

No bug you can't use `||` or `&&` operators in there – cmorrissey Apr 10 '15 at 19:29 — cmorrissey, Apr 10 '15 at 19:29

score 2 · Accepted Answer · answered Apr 10 '15 at 19:29

2

You can't use OR (||) and AND (&&) operators in a switch statement

answered Apr 10 '15 at 19:29

Sterling Archer

22,070
18
81
118

I saw "||" used when i searched on google, and first time worked fine so i taught that is corrent. My bad. – Andrei Telteu Apr 10 '15 at 19:35
3

Actually you "can": `switch (true) { case ($get == 'items' || $get == 'severalitems'): }` but yeah don't ;) – PeeHaa Apr 10 '15 at 19:36
That's no better than the if-elseif-else statement. – Andrei Telteu Apr 10 '15 at 19:37
1

I never said it was ;-) As a matter of fact I was pretty explicit about the not doing this part :D – PeeHaa Apr 10 '15 at 19:42

Mark Baker · Answer 2 · 2015-04-10T19:37:58.393

0

Then use

case 'items':
case 'several-items':
    echo 'items';
    break;

instead, especially as that is the documented method to use

otherwise you're testing against a case of the logical or of 'items' and 'several-items' (because || will always have the precedence), which is a boolean false; and your $get value will match that Boolean false unless it loose casts to a truthy value (ie is 1item or similar)

edited Apr 10 '15 at 19:37

answered Apr 10 '15 at 19:34

Mark Baker

209,507
32
346
385

PHP switch "||" not working properly

2 Answers2

Linked