Should the context of SQLiteOpenHelper always be the running activity?

Question

I want to open the database once only from the main screen of my app , and I want to use this instance anywhere in any activity. Is that possible or should I make the context to be each actual opened activity so that I must create an instance of the database ( open ) in every activity ?

Do this from Service or Application subclass (ApplicationContext), that way, you'll have the connection and lock/synchronisation available in any Activity — Marek Sebera, Apr 25 '15 at 11:30

Blackbelt · Accepted Answer · 2015-04-25T12:00:17.367

Is that possible or should I make the context to be each actual opened activity so that I must create an instance of the database ( open ) in every activity ?

it is possible, and you could use the application context. Your DBHelper could be a singleton. E.g

public class DBHelper extends SQLiteOpenHelper { 

  private static DBHelper sInstance;
  public static synchronized DBHelper getInstance(Context context) {    
    if (sInstance == null) {
       sInstance = new DBHelper(context.getApplicationContext());
    }
    return sInstance;
  }

  private DBHelper(Context context) {
    super(context, DATABASE_NAME, null, DATABASE_VERSION);
  }

}

it isn't unused ... *look closer* – Yash Sampat Apr 25 '15 at 11:48 — Yash Sampat, Apr 25 '15 at 11:48

score 3 · Answer 2 · edited May 23 '17 at 11:51

3

You do not need to close and re-open the SQL connection per each individual Activity.

Having said that - it is best to open the connection using an app context, to avoid Activity leaks.

You can get an app context refrence quite easily.

edited May 23 '17 at 11:51

Community

1
1

answered Apr 25 '15 at 11:35

Vaiden

15,728
7
61
91

Should the context of SQLiteOpenHelper always be the running activity?

2 Answers2