android-if condition doesn't work

Question

I have an android application and I have two EditTexts.

The user inputs 'distance' and 'time.

I made an if statement to show an error message if the user didn't filled one of the two inputs:

String strDistance,strTime;
strDistance=edtDistance.getText().toString();
strTime=edtTime.getText().toString();
if(strDistance==null||strTime==null){
    txtError.setText("Please insert the distance and time");
}
else{
    calculateLogic();
    app.setFare(fare);
    Intent intent=new Intent(MainActivity.this,Fare.class);
    startActivity(intent);
}

It works fine if I filled the two inputs.

But when I fill only one of them, the application stops working (I don't get my error message)...

check strDistance.equals(""), dont use strDistance == null. of course for two variable — Adem, Apr 27 '15 at 12:35
No, the `if` statement is not broken in Android nor Java... You question's title in kinda bad IMO... — shkschneider, Apr 27 '15 at 12:39
TextUtils.isEmpty(strDistance) || TextUtils.isEmpty(strTime) ? — Stan, Apr 27 '15 at 12:42
Java null check why use == instead of .equals(): https://stackoverflow.com/questions/4501061/java-null-check-why-use-instead-of-equals — shkschneider, Apr 27 '15 at 12:43

score 1 · Accepted Answer · edited Apr 27 '15 at 12:40

1

Try following this one:-

if(strDistance.equals("")||strTime.equals("") {
 txtError.setText("Please insert the distance and time");
}

edited Apr 27 '15 at 12:40

Dharma

3,007
3
23
38

answered Apr 27 '15 at 12:36

Bhuvnesh

1,055
9
29

Ankit Kumar · Answer 2 · 2015-04-27T16:20:04.460

0

 strDistance.gettext()

will never returns null.

 strDistance.isEmpty()

Use this

edited Apr 27 '15 at 16:20

answered Apr 27 '15 at 12:38

Ankit Kumar

3,663
2
26
38

Even if `edittext.setText(null)`? I mean "edittext.gettext() will never returns null" – Stan Apr 27 '15 at 12:39
it will return text string or empty, but never null. – Ankit Kumar Apr 27 '15 at 12:42

score 0 · Answer 3 · answered Apr 27 '15 at 12:39

Try trimming the result and using String.isEmpty(); This will ensure the text has a length of at least some text.

The reason to use isEmpty() is because EditText.getText() will never return null in its current implementation.

...
strDistance=edtDistance.getText().toString().trim();
strTime=edtTime.getText().toString().trim();

if(strDistance.isEmpty() || strTime.isEmpty()){
...

score 0 · Answer 4 · answered Apr 27 '15 at 12:46

Try this...

String strDistance,strTime;
strDistance=edtDistance.getText().toString();
strTime=edtTime.getText().toString();
if(strDistance.trim().isEmpty || strTime.trim().isEmpty()){
    Toast.makeText(getApplicationContext,"Please insert the distance and time",2000).show();
}
else{
    calculateLogic();
    app.setFare(fare);
    Intent intent=new Intent(MainActivity.this,Fare.class);
    startActivity(intent);
}

android-if condition doesn't work

4 Answers4