Cannot read property 'push' of undefined Javascript

Question

Hi it seams like i can't push my array ? code:

  $scope.arrResult = [];
  dpd.timesheets.get( function (result) {
    console.log(result);

    for (i = 0, n = result.length; i < n; i++) {
      var item = result[i];
      $scope.arrResult[item.week].push(item);
    }
    console.log($scope.arrResult);

  });

i get this console error

Uncaught TypeError: Cannot read property 'push' of undefined

if i set $scope.arrResult[item.week].push(item); to $scope.arrResult[item.week] = item; it works with no error but i need / want to push, whats wrong ?

AmmarCSE · Accepted Answer · 2015-05-20T13:07:06.817

12

This is because

$scope.arrResult[item.week]

itself is not an array.

push() is of Array.prototype

To see what I mean, try

$scope.arrResult[item.week] = [];

or

$scope.arrResult[item.week] = new Array();

and then try push()

edited May 20 '15 at 13:07

answered May 20 '15 at 13:02

AmmarCSE

30,079
5
45
53

I see, mmm.. but how do i do this the correct way then, if i set = [] before push, i just get one object in the array, and i want all :) – Stweet May 20 '15 at 13:07
@Stweet, what do you mean 'all'. Maybe don't even need an array? – AmmarCSE May 20 '15 at 13:08
result contaions alot of objects, and i want this objects sortet in $scope.arrResult[week] eg. $scope.arrResult[21] contains all objects of week 21 – Stweet May 20 '15 at 13:14
@Stweet, Ah! Use concat http://stackoverflow.com/questions/4156101/javascript-push-array-values-into-another-array – AmmarCSE May 20 '15 at 13:20
@Stweet So, if item is an array, then do $scope.arrResult[item.week].concat(item); – AmmarCSE May 20 '15 at 13:20
mmm it gives me Cannot read property 'concat' of undefined – Stweet May 20 '15 at 13:24
Did you do $scope.arrResult[item.week] = []; first? – AmmarCSE May 20 '15 at 13:25
but concat i also for array into array ? i want like arrResult[21] = object1, object2, object3..... – Stweet May 20 '15 at 13:25
no error with $scope.arrResult[item.week] = []; but it only gives me empty arrays :/ – Stweet May 20 '15 at 13:28
@Stweet, can you replicate the issue in a fiddle so I can better help? – AmmarCSE May 20 '15 at 13:29
https://jsfiddle.net/p8uzavrw/ as you see in console i got week 21 and 33 but they are empty, i want them to have the objects of week 21 and 33 :) – Stweet May 20 '15 at 13:38
Try it with push like in https://jsfiddle.net/p8uzavrw/1/ – AmmarCSE May 20 '15 at 13:45
i tried `outerArray[innerArray] = [];` and got `Uncaught SyntaxError: Unexpected token '[' ` – Andrew Jan 11 '16 at 23:41

Cannot read property 'push' of undefined Javascript

1 Answers1

Linked