Grabbing data from function

Question

I have this function:

function get_news($id) {
    $query      = mysql_query("SELECT `author`, `title`, `message` FROM `news` WHERE `id` = $id");
    $row        = mysql_fetch_array($query);
    $title      = $row['title'];
    $author_id  = $row['author'];
    $message    = $row['message'];
}

and on my page I have this:

get_news($_GET['id']);
echo $title . '<br />' . $message;

However, the echo is not working at all. How can I grab the data from the function to make it work in the echo?

You need to read a tutorial on how to use functions, you are missing some pretty basic things. — Epodax, May 26 '15 at 11:31
I think you have a scope problem - $title (etc.) is only available inside your function. — foxbeefly, May 26 '15 at 11:32

score 4 · Accepted Answer · answered May 26 '15 at 11:31

4

Just return $row. It contains all the data.

function get_news($id) {
    $query      = mysql_query("SELECT `author`, `title`, `message` FROM `news` WHERE `id` = $id");
    $row        = mysql_fetch_array($query);
    return $row;
}

And

$res = get_news($_GET['id']);
echo $res['title'] . '<br />' . $res['message'];

answered May 26 '15 at 11:31

Sougata Bose

31,517
8
49
87

Thanks, worked perfectly! – Vlammuh May 26 '15 at 11:47

Falt4rm · Answer 2 · 2015-05-26T11:33:00.043

0

Returning the array was enough.

function get_news($id) 
{
$query = mysql_query("SELECT `author`, `title`, `message` 
                      FROM `news` 
                      WHERE `id` = $id");
$row = mysql_fetch_array($query);

return $row;
}

In your page :

<? php
      print"<pre>";
      print_r(get_news($id));
     print"</pre>";
?>

edited May 26 '15 at 11:33

answered May 26 '15 at 11:31

Falt4rm

915
6
21

Grabbing data from function

2 Answers2