Why Dead code warning

Question

I have dead code warning at this position:

if("Email" == "+email.getText().toString()+"){
  Toast.makeText(getApplicationContext(), "email_id already available ", Toast.LENGTH_SHORT).show();
}

Can anyone help?

First use equals for comparing Strings instead of `==` – ρяσѕρєя K Jun 03 '15 at 09:00 — ρяσѕρєя K, Jun 03 '15 at 09:00

score 4 · Answer 1 · edited May 23 '17 at 11:51

4

if("Email" == "+email.getText().toString()+")

"Email" can never be equal to "+email.getText().toString()+"

You probably wanted to write

if("Email" == email.getText().toString())

and you should use the equal-Method to compare Strings:

if("Email".equals(email.getText().toString()))

You'll find more informations about comparing Strings in Java HERE

edited May 23 '17 at 11:51

Community

1
1

answered Jun 03 '15 at 09:00

B. Kemmer

1,517
1
14
32

yep it would work. but it definitely is bad code. you should use equal to compare Strings or Objects in java – B. Kemmer Jun 03 '15 at 09:06

score 4 · Answer 2 · answered Jun 03 '15 at 09:00

4

"Email" will never be equal to "+email.getText().toString()+". I think you wanted to use:

if ("Email".equals(email.getText().toString()))

answered Jun 03 '15 at 09:00

albertoqa

525
3
11

N J · Answer 3 · 2015-06-03T09:02:08.223

3

It should be

 if("Email".equals(mail.getText().toString()))
    {
     Toast.makeText(getApplicationContext(), "email_id already available ", Toast.LENGTH_SHORT).show(); 
    }

edited Jun 03 '15 at 09:02

answered Jun 03 '15 at 09:00

N J

27,217
13
76
96

score 0 · Answer 4 · answered Jun 03 '15 at 09:02

Replace "Email" == "+email.getText().toString()+" with "Email".equals(email.getText().toString())

Strings should always be compared using the equals() method.'

Also, consider defining constants, e.g.

public static final String KEY_EMAIL = "Email"

then use

if(email.getText().toString().equals(KEY_EMAIL)) {...}

score 0 · Answer 5 · answered Jun 03 '15 at 09:04

you should use

if(email.getText().toString().equals("Email"){ 
 Toast.makeText(getApplicationContext(), "email_id already available ", Toast.LENGTH_SHORT).show(); 
}

or use ignoreCaseEquals, explanation why it is dead code you must know by now by reading above answers

Why Dead code warning

5 Answers5

Linked