Parse error: syntax error, unexpected 'mytable' (T_STRING)

Question

Can anybody tell me what is wrong with my code? I cant seem to solve this error:

Parse error: syntax error, unexpected 'mytable' (T_STRING) in E:\XAMP server\htdocs\fyp\login.php on line 11

<?php

    $user = ‘minzhe’;
    $pswd = ‘2818327’;
    $db = ‘trial’;
    $conn = mysql_connect(‘localhost’, $user, $pswd);
    mysql_select_db($db, $conn);

    $un = $_POST['username'];
    $pw = $_POST['password'];

    $query = “SELECT * FROM mytable WHERE username = ‘$un’ AND password =  ‘$pw’”;
    $result = mysql_query($query);

    if(mysql_num_rows($result) >0)
        echo 1;
    else
        echo 0;

?>

If you can, you should [stop using `mysql_*` functions](http://stackoverflow.com/questions/12859942/why-shouldnt-i-use-mysql-functions-in-php). They are no longer maintained and are [officially deprecated](https://wiki.php.net/rfc/mysql_deprecation). Learn about [prepared](http://en.wikipedia.org/wiki/Prepared_statement) [statements](http://php.net/manual/en/pdo.prepared-statements.php) instead, and consider using PDO, [it's really not hard](http://jayblanchard.net/demystifying_php_pdo.html). — Jay Blanchard, Jun 09 '15 at 14:54
[Your script is at risk for SQL Injection.](http://stackoverflow.com/questions/60174/how-can-i-prevent-sql-injection-in-php) — Jay Blanchard, Jun 09 '15 at 14:54
[Don't limit passwords](http://jayblanchard.net/security_fail_passwords.html) and [use the proper methods to hash passwords with PHP](http://jayblanchard.net/proper_password_hashing_with_PHP.html). — Jay Blanchard, Jun 09 '15 at 14:54

score 1 · Answer 1 · answered Jun 09 '15 at 14:53

1

Don't use a word processor to edit your code:

$user = ‘minzhe’;
        ^------^

You've got "smart quotes" everywhere, and they are NOT valid quotes in PHP. They have to be ' or ".

You are also vulnerable to sql injection attacks.

answered Jun 09 '15 at 14:53

Marc B

356,200
43
426
500

OP clearly doesn't show us the real code. Because otherwise he would have an error on line 2 – Rizier123 Jun 09 '15 at 14:56
1

Show a man how to fish, I always say ;-) – Funk Forty Niner Jun 09 '15 at 14:58

score 0 · Answer 2 · answered Jun 09 '15 at 14:54

0

your computer is defaulting to curvy quotation marks. which PHP cannot read;

“ should be replaced with "

and ‘ should be replaced with '

answered Jun 09 '15 at 14:54

Dimi

1,255
11
20

Parse error: syntax error, unexpected 'mytable' (T_STRING)

2 Answers2