PHP Mail - can't find mistake

Question

So this is my code for sending an email. When I try to send an email i get right message, in this case "User Exist" and "Email is sent", but i can't receive an email. So can somebody find mistake and try to help me?

<form action="forgot2.php" method="post">
Enter you email ID: <input type="text" name="email">
<input type="submit" name="submit" value="Send">
</form>

error_reporting(0);
$email=$_POST["email"];
$Subject = "GOSPodin covek";

if($_POST['submit']=='Send')
{
    mysql_connect('localhost','root','') or die(mysql_error);
    mysql_select_db('login');
    $query="select * from clanovi where email='$email'";
    $result=mysql_query($query) or die(error);
    if(mysql_num_rows($result))
    {
        echo "User exist"; 
    }
    else
    { 
        echo "No user exist with this email id";
    }
}

if(mysql_num_rows($result))
{
    $code=rand(100,999);
    $message="You activation link is: http://localhost/login_form/forgot.php?          email=$email&code=$code";
    mail($email, "Subject Goes Here", $message);
    echo "Email sent"; 
}
else
{
    echo "No user exist with this email id";
}

While not the answer to your question, please read about sql injections, because your code allows them: https://en.wikibooks.org/wiki/PHP_Programming/SQL_Injection_Attacks and https://xkcd.com/327/ — Tilman Hausherr, Jun 27 '15 at 17:26
You do realize that, outside the SQL injection issue, the code is highly hackable? `$code=rand(100,999);` makes the recovery URL in no way unique or linked to the user. Generate a unique recovery hash and store it in a column in your user table instead. — Markus AO, Jun 27 '15 at 17:31
/* Watch this space for comments about not using the deprecated `mysql_*` extension and using `mysqli_*` instead. */ — Markus AO, Jun 27 '15 at 17:33

Markus AO · Answer 1 · 2015-06-27T17:25:38.773

First of all, you need to check if the mail is actually sent:

if (mail($email, "Subject Goes Here", $message)) {
    // then it's actually sent.
}

If mail() doesn't return false, then the mail was passed to your local mail server for delivery. Presume you already have a mail server set up on your local test box? If not, problem is obvious...

If PHP checks out OK and you still don't receive the mail (and it's not in your spam folders etc.), you need to investigate your server's mail logs for possible issues outside PHP.

...and for the love of code and all things sacred to debugging, do NOT use error_reporting(0); if you're actually trying to figure out what's wrong! (Error messages are kinda helpful for that.)

score 0 · Answer 2 · answered Jun 27 '15 at 17:19

0

Are you sure your script is actually sending the mail?

Replace:

mail($email, "Subject Goes Here", $message);
echo "Email sent";

By:

if(@mail($email, "Subject Goes Here", $message)) {
  echo "Email sent";
} else {
  echo "Email not sent";
}

answered Jun 27 '15 at 17:19

Eduardo Escobar

3,301
2
18
15

2

That's cool, but why `@mail` suppress the possible error if we're still debugging? – Markus AO Jun 27 '15 at 17:24

Deepak Kumar · Answer 3 · 2015-06-27T17:41:22.550

0

Just try

I use this works fine for me

$headers = 'From: support@example.com';
mail($payer_email, 'Tokens', "Thank you for purchase tokens $additional-message", $headers);

edited Jun 27 '15 at 17:41

answered Jun 27 '15 at 17:25

Deepak Kumar

413
1
4
11

That would fail very much, since your code would try to send the mail literally to `<$email>`. Strings in single quotes aren't parsed for variables. – Markus AO Jun 27 '15 at 17:28
`mail($payer_email, 'Tokens', "Thank you for purchase tokens", $headers);` this works fine for me – Deepak Kumar Jun 27 '15 at 17:35
@DeepakKumar - You're using `'$email'` here, though. That will use the string literal `$email`, because you're using single quotes. You need to remove the quotes. – andrewsi Jun 27 '15 at 17:40
Try `mail('$payer_email'...` with the single quotes and see how it goes. – Markus AO Jun 27 '15 at 17:40
Ok i was not sure so edited my answer – Deepak Kumar Jun 27 '15 at 17:41

score 0 · Answer 4 · answered Jun 27 '15 at 17:30

0

Assuming mail() does return true and that the email is a valid one, you want to make you have a valid smtp server configured in php.ini in the [mail function] section.

answered Jun 27 '15 at 17:30

mcorne

77
2

score 0 · Answer 5 · edited Jun 27 '15 at 20:39

0

change this one.

$query="select * from clanovi where email='".$email."'";

edited Jun 27 '15 at 20:39

Cyclonecode

29,115
11
72
93

answered Jun 27 '15 at 17:38

Gulim Shah

194
7

1

What difference will that make? PHP is already going to interpolate the variable into the string, as it's using double quotes – andrewsi Jun 27 '15 at 17:39

PHP Mail - can't find mistake

5 Answers5