jQuery More & Less Than

Question

I'm trying to display an alert if the value is equal or great than the minimum value and less than the maximum set value. Some how if I set dob to '01-09-1996' the alert is still triggered? Would somebody point out what I'm doing wrong? Thank you.

$(function() {
    $('#date1 input').autotab_magic().autotab_filter('numeric');

    $(".eligibilityform").submit(function(e) {

        // Input Values
        var day = $("#day").val();
        var month = $("#month").val();
        var year = $("#year").val();

        // DOB Value
        var dob = new Date(day + '-' + month + '-' + year);

        // DOB Rules
        var mindob = new Date("01-09-1996");
        var maxdob = new Date("31-08-2000");

        // DOB Eligibility
        if (dob >= mindob && dob <= maxdob) {
            alert("Welcome");

            // Season Eligibility
            var spring2015min = new Date("01-09-1997");
            var spring2015max = new Date("31-08-1998");
            if (dob >= spring2015min && dob <= spring2015max) {
                alert("Spring 2015");
            }
            var summer2015min = new Date("01-09-1997");
            var summer2015max = new Date("31-08-1999");
            if (dob >= summer2015min && dob <= summer2015max) {
                alert("Summer 2015");
            }
            var autumn2015min = new Date("01-01-1998");
            var autumn2015max = new Date("31-08-1999");
            if (dob >= autumn2015min && dob <= autumn2015max) {
                alert("Autumn 2015");
            }
            var spring2016min = new Date("01-09-1998");
            var spring2016max = new Date("31-08-1999");
            if (dob >= spring2016min && dob <= spring2016max) {
                alert("Spring 2016");
            }
            var summer2016min = new Date("01-09-1998");
            var summer2016max = new Date("31-08-2000");
            if (dob >= summer2016min && dob <= summer2016max) {
                alert("Summer 2016");
            }
            var autumn2016min = new Date("01-01-1998");
            var autumn2016max = new Date("31-08-2000");
            if (dob >= autumn2016min && dob <= autumn2016max) {
                alert("Autumn 2016");
            }

        } else {
            alert("Sorry");
        }

        return false;
    });
});

Answer

// Eligibility
$(function() {
  $('#date1 input').autotab_magic().autotab_filter('numeric');
  $('.error-message').hide();
  $('.success-message').hide();
  $('.seasons').hide();
  $('.seasons li').hide();
  $(".eligibilityform").submit(function(e){
    // Input Values
    var day = $("#day").val();
    var month = $("#month").val();
    var year = $("#year").val();
    // DOB Value
    var dob = new Date(month+'/'+day+'/'+year);
    // DOB Rules
    var mindob = new Date("09/01/1997");
    var maxdob = new Date("08/31/2000");
    // DOB Eligibility
    if (dob >= mindob && dob <= maxdob) {
      $('.success-message').show();
      $('.intro-message').hide();
      $('.error-message').hide();
      $('.eligibilityform').hide();
      $('.seasons').show();
      // Season Eligibility
      var spring2015min = new Date("09/01/1997");
      var spring2015max = new Date("08/31/1998");
      if (dob >= spring2015min && dob <= spring2015max){
              $('.seasons li.one').show();
      }
      var summer2015min = new Date("09/01/1997");
      var summer2015max = new Date("08/31/1999");
      if (dob >= summer2015min && dob <= summer2015max){
        $('.seasons li.two').show();
      }
      var autumn2015min = new Date("01/01/1998");
      var autumn2015max = new Date("08/31/1999");
      if (dob >= autumn2015min && dob <= autumn2015max){
        $('.seasons li.three').show();
      }
      var spring2016min = new Date("09/01/1998");
      var spring2016max = new Date("08/31/1999");
      if (dob >= spring2016min && dob <= spring2016max){
        $('.seasons li.four').show();
      }
      var summer2016min = new Date("09/01/1998");
      var summer2016max = new Date("08/31/2000");
      if (dob >= summer2016min && dob <= summer2016max){
        $('.seasons li.five').show();
      }
      var autumn2016min = new Date("01/01/1998");
      var autumn2016max = new Date("08/31/2000");
      if (dob >= autumn2016min && dob <= autumn2016max){
        $('.seasons li.six').show();
      }
    } else {
      $('.intro-message').hide();
      $('.success-message').hide();
      $('.error-message').show();
    }
    return false;
  });
});

Answer 1

This is because you are attempting to use the >= and <= operators on a string.

You need to convert your string into a Date object

var d = new Date(year, month, day, hours, minutes, seconds, milliseconds);

See Here

You can then compare the dates

  var dob = new Date("09-01-1996");
  var spring2015min = new Date("09-01-1997");
  var spring2015max = new Date("08-31-1998");
  if (dob >= spring2015min && dob <= spring2015max){
    alert("Spring 2015");
  }

Update: In your case the Date object will take the format string as (MM-dd-yyyy)

You can see it working here : JSFiddle

Answer 2

The issue is that you can't compare dates that way, only integers. I would use something like this:

if( (new Date(dob).getTime() >= new Date(spring2015min).getTime()))

Answer 3

The current test that you are doing is string checking so it will test the actual strings are equal or their numerical character equivalents are greater than its numerical value. You should convert your strings to dates by using new Date() then do your checks on the date objects