avoid using if clause

Question

I am trying to log information within my system.Whenever logging I do a check if a state is valid and only then do I log that information.

//doing this logging all over the place in my code base. 
if(checkIsValid){
  Object obj =new Object(string1,Integer2,........String10);
  log(obj);
}

The question here is how do I refactor my code so that I don't have to repeat this block of code everywhere for logging.

One of the solution is I could write a supplementary method like this.

 method(String1,Integer2,......String10){
  if(checkIsValid){
  Object obj =new Object(string1,Integer2,.........String10);
  log(obj);
  }
}

But the downside is that I would have to pass a number of strings as arguments to my method which does not look clean at all.

If you don't want to pass 10 parameters, you should consider passing `List` — Karthik, Jul 10 '15 at 09:34
But then I would be creating an object every time and discarding it if the check fails which is still not a good optimization! — luckysing_noobster, Jul 10 '15 at 09:34
It could be a mix a sting and integer arguments see the edit! — luckysing_noobster, Jul 10 '15 at 09:36
Not exactly a duplicate, but very helpful: http://stackoverflow.com/questions/31121513/is-there-an-elegant-way-to-make-every-method-in-a-class-start-with-a-certain-blo — SpaceTrucker, Jul 10 '15 at 10:25

score 4 · Answer 1 · answered Jul 10 '15 at 09:37

4

If you are using log4j for logging you can extends the logger class and overwrite the log, debug, error .... etc methods with your own validation.

If not you can do as you say: create a new method as below:

  public void validateAndLog(Object obj){
       if(checkIsValid){
          log(obj);
       }
  }

OR

 public void validateAndLog(String... strs){
           if(checkIsValid){
              log(Arrays.toString(strs));
           }
      }

answered Jul 10 '15 at 09:37

Ali Helmy

784
6
18

Note how the second example uses varargs - this lets you pass as many strings as you like to the method, as individual arguments to the method, and treats it as an array inside the method. – Carl Manaster Jul 10 '15 at 14:40

nucleon · Answer 2 · 2015-07-10T09:52:04.530

0

You could use a factory function for your object similar to

public Object createObjChecked(String1,......String10){
    Object obj = null;
    if(checkIsValid(String1, ..., String10)){
        obj = new Object(string1,.........String10);
        log(obj);
    }
    return obj;
}

Then you could check if the object was actually created at usage location.

edited Jul 10 '15 at 09:52

answered Jul 10 '15 at 09:39

nucleon

1,128
1
6
19

score 0 · Answer 3 · answered Jul 10 '15 at 12:14

You solution is good. You are only missing passing varargs:

void myLogMethod(String format, Object args){
  if(checkIsValid){
    Object obj = new Object(format, args);
    log(obj);
  }
}

This is the kind of approach taken by slf4j. See http://www.slf4j.org/apidocs/org/slf4j/Logger.html

avoid using if clause

3 Answers3

Linked