How to implement Android ImageGetter for big images?

Question

I am showing HTML into TextView:

    String html = "Hello " +
            "<img src='http://www.gravatar.com/avatar/" +
            "f9dd8b16d54f483f22c0b7a7e3d840f9?s=32&d=identicon&r=PG'/>" +
            " This is a test " +
            "<img src='http://www.gravatar.com/avatar/a9317e7f0a78bb10a980cadd9dd035c9?s=32&d=identicon&r=PG'/>";

    Spanned htmlSpan = Html.fromHtml(html, imageParser, null);
    textView.setText(htmlSpan);

The following ImageParser does the job:

  public class URLImageParser implements Html.ImageGetter {
Context c;
View container;

/***
 * Construct the URLImageParser which will execute AsyncTask and refresh the container
 * @param t
 * @param c
 */
public URLImageParser(View t, Context c) {
    this.c = c;
    this.container = t;
}

public Drawable getDrawable(String source) {
    URLDrawable urlDrawable = new URLDrawable();

    // get the actual source
    ImageGetterAsyncTask asyncTask =
            new ImageGetterAsyncTask( urlDrawable);

    asyncTask.execute(source);

    // return reference to URLDrawable where I will change with actual image from
    // the src tag
    return urlDrawable;
}

public class ImageGetterAsyncTask extends AsyncTask<String, Void, Drawable> {
    URLDrawable urlDrawable;

    public ImageGetterAsyncTask(URLDrawable d) {
        this.urlDrawable = d;
    }

    @Override
    protected Drawable doInBackground(String... params) {
        String source = params[0];
        return fetchDrawable(source);
    }

    @Override
    protected void onPostExecute(Drawable result) {
        // set the correct bound according to the result from HTTP call
        urlDrawable.setBounds(0, 0, 0 + result.getIntrinsicWidth(), 0
                + result.getIntrinsicHeight());

        // change the reference of the current drawable to the result
        // from the HTTP call
        urlDrawable.drawable = result;

        // redraw the image by invalidating the container
        URLImageParser.this.container.invalidate();
    }

    /***
     * Get the Drawable from URL
     * @param urlString
     * @return
     */
    public Drawable fetchDrawable(String urlString) {
        try {
            InputStream is = fetch(urlString);
            Drawable drawable = Drawable.createFromStream(is, "src");
            drawable.setBounds(0, 0, 0 + drawable.getIntrinsicWidth(), 0
                    + drawable.getIntrinsicHeight());
            return drawable;
        } catch (Exception e) {
            return null;
        }
    }

    private InputStream fetch(String urlString) throws MalformedURLException, IOException {
        DefaultHttpClient httpClient = new DefaultHttpClient();
        HttpGet request = new HttpGet(urlString);
        HttpResponse response = httpClient.execute(request);
        return response.getEntity().getContent();
    }
}

}

But it does not work with bigger images. The String that does not work is as follows:

  String html = "Hello " +
            "<img src='http://darwin.suav.biz/image/data/produse/Tablete/Apple/Ipad 4/hero_slide1.png" +
            " This is a test " +
            "<img src='http://www.gravatar.com/avatar/a9317e7f0a78bb10a980cadd9dd035c9?s=32&d=identicon&r=PG'/>";

It crashes with the following error:

java.lang.NullPointerException
        at md.darwin.catalog.manager.URLImageParser$ImageGetterAsyncTask$1.run(URLImageParser.java:70)
        at android.os.Handler.handleCallback(Handler.java:733)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at android.os.Looper.loop(Looper.java:136)
        at android.app.ActivityThread.main(ActivityThread.java:5038)
        at java.lang.reflect.Method.invokeNative(Native Method)
        at java.lang.reflect.Method.invoke(Method.java:515)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
        at dalvik.system.NativeStart.main(Native Method)

And URLImageParser.java:70 is:

              urlDrawable.setBounds(0, 0, result.getIntrinsicWidth(), result.getIntrinsicHeight());

I have also tried with Picasso, the method found here: https://github.com/aegis123/Bettyskitchen-app/blob/master/BettysKitchen-app/src/main/java/com/bettys/kitchen/recipes/app/Utils/ImageGetter.java

But I get error(no crash): Failed to decode stream

Does anyone know what would be the issue with bigger images? Why would it be Null inside onPostExecute?

Answer 1

You have to log and check what that catch(Exception e) is catching. It's obvious that there's an exception there and fetchDrawable() is returning null. But you're not properly analysing/checking it, there's no way to know what's wrong there.

Thank you. This helped. I did not even suppose my imageURL was bad. Now everything works with InputStream with bigger images.

Glad it worked. If I were you I would apply Picasso and not use AsyncTask. Picasso Threading is much more fine tuned then AsyncTask and it have 2 level (RAM n Disk) caching.

Answer 2

Have you try to enable the application Heap ?

android:largeHeap="true"

on the element in the manifest

or just try with other image getter library like 'ion'

(https://github.com/koush/ion)

Answer 3

I would go with one of the common image loaders to perform this task. There are many pitfalls that you can avoid.

Take a look here: Any best third party tool to cache image in Android?