Sequelize create model with beforeCreate hook

Question

I defined my hook beforeCreate as following:

module.exports = function (sequelize, DataTypes) {
  var userSchema = sequelize.define('User', {
  // define...
  });
  userSchema.beforeCreate(function (model) {
    debug('Info: ' + 'Storing the password');    
    model.generateHash(model.password, function (err, encrypted) {
      debug('Info: ' + 'getting ' + encrypted);

      model.password = encrypted;
      debug('Info: ' + 'password now is: ' + model.password);
      // done;
    });
  });
};

and when I create a the model

  User.create({
    name:           req.body.name.trim(),
    email:          req.body.email.toLowerCase(),
    password:       req.body.password,
    verifyToken:    verifyToken,
    verified:       verified
  }).then(function (user) {
    debug('Info: ' + 'after, the password is ' + user.password);    
  }).catch(function (err) {
    // catch something
  });

Now what I get from this is

Info: Storing the password +6ms
Info: hashing password 123123 +0ms    // debug info calling generateHash()
Executing (default): INSERT INTO "Users" ("id","email","password","name","verified","verifyToken","updatedAt","createdAt") VALUES (DEFAULT,'wwx@test.com','123123','wwx',true,NULL,'2015-07-15 09:55:59.537 +00:00','2015-07-15 09:55:59.537 +00:00') RETURNING *;

Info: getting $2a$10$6jJMvvevCvRDp5E7wK9MNuSRKjFpieGnO2WrETMFBKXm9p4Tz6VC. +0ms
Info: password now is: $2a$10$6jJMvvevCvRDp5E7wK9MNuSRKjFpieGnO2WrETMFBKXm9p4Tz6VC. +0ms
Info: after, the password is 123123 +3ms

It seems that every part of the code is working. Creating a user schema will invoke beforeCreate, which properly generates the hash code for the password.... except it didn't write to the database!

I'm certain that I'm missing a very important and OBVIOUS piece of code, but I just can't find where the problem is (aghh). Any help appreciated!

score 39 · Accepted Answer · answered Jul 15 '15 at 10:51

39

Hooks are called in an asynchronous fashion in Sequelize, so you need to call the completion callback when you're done:

userSchema.beforeCreate(function(model, options, cb) {
  debug('Info: ' + 'Storing the password');    
  model.generateHash(model.password, function(err, encrypted) {
    if (err) return cb(err);
    debug('Info: ' + 'getting ' + encrypted);

    model.password = encrypted;
    debug('Info: ' + 'password now is: ' + model.password);
    return cb(null, options);
  });
});

(alternatively, you can return a promise from the hook)

answered Jul 15 '15 at 10:51

robertklep

198,204
35
394
381

@user2242178 don't worry, glad to hear it solved your problem :-) – robertklep Jul 15 '15 at 17:01
Thank you. I didn't see this on sequelize documentation, and it was preventing my server to respond. – Danielo515 Apr 27 '16 at 10:44
@Danielo515 yeah it's not very clearly documented :-( – robertklep Apr 27 '16 at 10:47
1

updated version of sequlize does not have a callback function – Aryeh Armon Nov 05 '17 at 08:52
@AryehArmon return a promise instead. – robertklep Nov 05 '17 at 08:54
@robertklep how would i use a function with a callback with promises – Aryeh Armon Nov 05 '17 at 08:57
@AryehArmon https://stackoverflow.com/questions/22519784/how-do-i-convert-an-existing-callback-api-to-promises – robertklep Nov 05 '17 at 09:00

score 20 · Answer 2 · answered Nov 24 '17 at 00:10

20

For newer versions of Sequelize, the hooks no longer have callback functions but promisses. Therefor the code would look more like the following:

userSchema.beforeCreate(function(model, options) {
    debug('Info: ' + 'Storing the password');

    return new Promise ((resolve, reject) => {
        model.generateHash(model.password, function(err, encrypted) {
            if (err) return reject(err);
            debug('Info: ' + 'getting ' + encrypted);

            model.password = encrypted;
            debug('Info: ' + 'password now is: ' + model.password);
            return resolve(model, options);
        });
    });
});

answered Nov 24 '17 at 00:10

Rene

466
5
12

Does sequelize support async/await functions in the model hooks? – Jadex1 Jan 01 '18 at 18:47
Async/await functions arent implemented in node yet, so when you write Async/Await it is transpiled back to promises by Babel – Rene Jan 01 '18 at 18:51
I thought async/await was released with node 8 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/async_function I don't use babel in my project, and my code compiles with the async/await functions. Could you explain please? – Jadex1 Jan 01 '18 at 18:59
Oh i guess you're right, but the release notes say that async await uses promises so it should still be fine – Rene Jan 01 '18 at 19:06

Sequelize create model with beforeCreate hook

2 Answers2

Linked