How to get returned object from different action on sails.js?

Question

I'm still new to sails.js and currently trying to get returned object from different action.

What currently I know is if I use 'getUserTransaction' action inside 'UserController', then I can only return it to 'getUserTransaction.ejs' view using locals (_.each). (CMIIW) example:

//UserController
getUserTransaction: function (req, res, next){
   UserTransaction.find({user:req.param('userid')}).exec(function foundTransactions(err, transactions){
      if(err) return next(err);

      if(!transactions) return next();

      res.view({
         transactions: transactions
      });
   });
}

//getUserTransaction.ejs 
...
<% _.each(transactions, function(transaction){ %>
   <tr>
       <td><%= transaction.data %></td>
       <td><a href="<%= transaction.path %>">Link</a></td>
   </tr>
<% }); %>
...

But, what if I want to return object from 'getUserHobby' action indside 'UserController' to 'getUserTransaction.ejs' view?. this is my code and I can't get it right

//UserController
getUserHobby: function (req, res, next){
   UserHobby.find({user:req.param('userid')}).exec(function foundHobbies(err, hobbies){
      if(err) return next(err);

      if(!hobbies) return next();

      res.view('user/getUserTransaction', {
         hobbies: hobbies
      });
   });
}

//getUserTransaction.ejs
...
<% _.each(hobbies, function(hobby){ %>
   <tr>
       <td><%= hobby.type %></td>
       <td><%= hobby.name %></td>
   </tr>
<% }); %>
...

And I've tried to do it and returned 'hobbies undefined'. So how I should get it right.

Regards

Answer 1

First of, in a Sails controller action, you shouldn't use the 3rd param (next).

Unlike Express middleware methods, Sails controller actions should always be the last stop in the request chain--that is, they should always result in either a response or an error. While it is possible to use next in an action method, you are strongly encouraged to use policies instead wherever possible.

You should use the built in response methods even if you want to throw an error.

Here is how I would write my controller action:

// Inside api/controllers/UserController.js
getUserTransactions: function (req, res) {
  if(!req.param('userid'))
    return res.badRequest(); // Send a 400 response back down to the client indicating that the request is invalid

  UserTransaction
    .find({ user: req.param('userid') })
    .exec(function foundTransactions(err, transactions){
      if(err)
        return res.negotiate(err); // Send an appropriate error response back down to the client

      // If there is no transactions, you can display a message in your view
      return res.ok({ transactions: transactions }); // Send a 200 ("OK") response back down to the client with the provided data
  });
}

And here is how you could write your corresponding view:

// Inside views/user/getUserTransaction.ejs
<% if(data.transactions.length) { %>
    <!-- display each transactions... -->
    ...
<% } else { %>
    <p>This user has no transaction yet.</p>
<% } %>

---

For your other action, here is how you can use res.ok with a pathToView param

res.ok({ hobbies: hobbies }, 'user/getUserTransactions');

Your view has to be located in the views/user/getUserTransactions.ejs file in order to run correctly.

---

Now we've reviewed your code, we can answer your question.

So you want to call an controller's action in another one. This is possible but not recommended.

Here is what you should do:

// api/controllers/UserController.js
// In your getUserTransactions method (you should change its name)
// Get the user transactions
UserTransaction
  .find({ user: req.param('userid') })
  .exec(function foundTransactions(err, transactions) {
    if(err) return res.negotiate(err);

    // Get the user hobbies
    UserHobby
      .find({ user: req.param('userid') })
      .exec(function foundHobbies(err, hobbies) {
        if(err) return res.negotiate(err);

        return res.ok({
          transactions: transactions,
          hobbies: hobbies
        });
   });
});

You can also use services to simplify your controllers.

// api/services/UserService.js
module.exports.getUserTransactions = function (userId, cb) {
  UserTransaction
    .find({ user: userId })
    .exec(cb);
};

module.exports.getUserHobbies = function (userId, cb) {
  UserHobby
    .find({ user: userId })
    .exec(cb);
};

// Inside api/controllers/UserController.js
UserService
  .getUserTransactions(req.param('userid'), function (err, transactions) {
    if(err) return res.negotiate(err);

    UserService
      .getUserHobbies(req.param('userid'), function (err, hobbies) {
        if(err) return res.negotiate(err);

        return res.ok({
          transactions: transactions,
          hobbies: hobbies
        });
    });
});