How I can check if the element of a list is the last?

Question

I'm trying to do something like:

{"semaforo":"icbc"},{"semaforo":"pepito"}

I have the following code:

for (Iterator it = semaforosMiddleware.iterator(); it.hasNext();) {
    KeyMapMediciones semaforoMiddleware = (KeyMapMediciones) it.next();
    jsonFamilias.append("{\"semaforo\":\"" + semaforoMiddleware.getAplicacion() + "\"}");
    if (it.hasNext()) {
        jsonFamilias.append(",");
    }
}

But I get output like:

{"semaforo":"icbc"},{"semaforo":"pepito"},

I don't want the final comma (",") after the last element. What can I do?

Have a look at [Guava's Joiner](https://code.google.com/p/guava-libraries/wiki/StringsExplained) — wjans, Aug 04 '15 at 12:54

score 13 · Answer 1 · answered Aug 04 '15 at 12:57

13

The nicest and simplest trick I learned on this site:

String separator = "";
for (String s : coll) {
   buf.append(separator).append(s);
   separator = ",";
}

answered Aug 04 '15 at 12:57

Marko Topolnik

195,646
29
319
436

1

Haha I love it. Stupid and elegant. – Jean Logeart Aug 04 '15 at 13:07

score 3 · Accepted Answer · answered Aug 04 '15 at 12:55

The code you posted works fine. Here's a simplified runnable example:

import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;


public class Test {
    public static void main(String... args){

        List<String> list = new ArrayList<>();
        list.add("one");
        list.add("two");
        list.add("three");

        StringBuilder sb = new StringBuilder();

        for (Iterator<String> it = list.iterator(); it.hasNext();) {
            String element = it.next();
            sb.append(element);
            if(it.hasNext()){
                sb.append(", ");
            }
        }

        System.out.println(sb.toString()); //prints: one, two, three

    }
}

SubOptimal · Answer 3 · 2015-08-04T13:14:03.277

3

Find below a Java 8 solution.

public static void main(String[] args) {
    List<String> list = new ArrayList<>();
    list.add("one");
    list.add("two");
    list.add("three");

    String toString = list.stream().collect(Collectors.joining(", "));
    System.out.println("toString = " + toString);
}

output

toString = one, two, three

edited Aug 04 '15 at 13:14

answered Aug 04 '15 at 13:09

SubOptimal

22,518
3
53
69

score 1 · Answer 4 · answered Aug 04 '15 at 12:53

You can check for the first element instead (i.e. add a comma before each element except the first element) :

boolean first = true;
for (Iterator it = semaforosMiddleware.iterator(); it.hasNext();) {
    if(!first){
        jsonFamilias.append(",");
    } else {
        first = false;
    }
    KeyMapMediciones semaforoMiddleware = (KeyMapMediciones) it.next();
    jsonFamilias.append("{\"semaforo\":\"" + semaforoMiddleware.getAplicacion() + "\"}");
}

score 0 · Answer 5 · answered Aug 04 '15 at 12:56

0

Alternatively, you can also do:

String jsonFamilias = semaforosMiddleware.stream()
                        .map(s -> "{\"semaforo\":\"" + s.getAplicacion() + "\"}")
                        .collect(Collectors.joining(","));

answered Aug 04 '15 at 12:56

Jean Logeart

52,687
11
83
118

possible in for Java8+ – Muhammad Suleman Aug 04 '15 at 13:01
Absolutely. People should use it. This snippet is so much cleaner – Jean Logeart Aug 04 '15 at 13:04
okay, Actually its not just clean code rather people have some other serious issues like supporting application made in previous version – Muhammad Suleman Aug 05 '15 at 06:20

GregH · Answer 6 · 2015-08-04T13:06:56.723

0

StringBuilder stringBuilder = new StringBuilder("");
stringBuilder.append(Joiner.on(", ").join(semaforosMiddleware));
String resultString = stringBuilder.toString();

The use of a Joiner makes these scenarios much easier to handle.

edited Aug 04 '15 at 13:06

answered Aug 04 '15 at 13:01

GregH

5,125
8
55
109

How I can check if the element of a list is the last?

6 Answers6