Android JsonObject -- I do not know what to do

Question

I can not use the data from the method. I do not know why. Where did the mistake? I have the following json:

{"code":"1","status":"Basarili","login":"OK","kullanici":"1"}

JSONObject veri_json;
try {
    veri_json = new JSONObject(response); 
    try {
        String code,status,login,kullanici;
        code = veri_json.getString("code").toString();
        status = veri_json.getString("status").toString();
        login = veri_json.getString("login").toString();
        kullanici = veri_json.getString("kullanici").toString();

        if(code=="1") {
            etKullanici.setText(status);
        }

    } 
    catch (JSONException e) {
        // TODO Auto-generated catch block
        e.printStackTrace();  
    }
} 
catch (JSONException e) {
    // TODO Auto-generated catch block
    e.printStackTrace();
}

Debugger note:

code="1" login="OK" status="Basarili" kullanici="1"

but doesn't work

if(code=="1") {
    etKullanici.setText(status);
}

I am sorry for my bad English.

Did you even try to search "How to compare strings in Java" on Google/Bing? — Rohit5k2, Aug 14 '15 at 08:50

score 2 · Answer 1 · answered Aug 14 '15 at 08:26

2

Your variable "code" is a string. You need to check the value not the reference. Change it to:

if (code.equals("1"))

answered Aug 14 '15 at 08:26

Thomas R.

7,988
3
30
39

score 1 · Accepted Answer · answered Aug 14 '15 at 08:28

JSONObject veri_json; try { veri_json = new JSONObject(response);

                                try {
                                    String code,status,login,kullanici;
                                    code = veri_json.getString("code");
                                    status = veri_json.getString("status");
                                    login = veri_json.getString("login");
                                    kullanici = veri_json.getString("kullanici");


                                    if(code.equalsIgnoreCase("1")) {
                                        etKullanici.setText(status);
                                    }

} catch (JSONException e) {
                                // TODO Auto-generated catch block
                                e.printStackTrace();
                            }
                        } catch (JSONException e) {
                            // TODO Auto-generated catch block
                            e.printStackTrace();
                        }

in above code i have to remove toString while u get object data. You have to tried above code it works like charm

score 1 · Answer 3 · answered Aug 14 '15 at 08:28

1

You must compare the String with

String.equals()

Like:

if (code.equals("1")) {...}

code == "1" tests for reference equality (so it will never return true because "1" is the same as new String("1"), which isn't the same object as code.

answered Aug 14 '15 at 08:28

DominicM

2,186
5
24
42

Android JsonObject -- I do not know what to do

3 Answers3