HashMap Concurrent Modification

Question

I am trying to check the server's entities and iterate trough them each second, and if I find one who is not spawned anymore,it will respawn automatically.

The problem occurs when, in my EntitySpawnEvent I remove the old entity from the hashmap and add a new one, this creating a java.util.ConcurrentModificationException. Is there any possibility I can least suppress this errors? (Because I am removing an Entity that the "check" already passed through.)

new BukkitRunnable() {
        public void run() {
            for(Entity e : CheckAliveEntities.keySet()) {
                if(!(e.isValid())) {
                        if(!(e instanceof Player)) {
                            System.out.println("DA");
                            x.removeHologram(e);
                            y.setEntityRespawn(e);
                            break;
                        }
                }
            }
        }       
    }.runTaskTimer(this, 5, 5);

You can use ConcurrentHashMap if it is multithreaded environment. if single threaded environment you can refer to this post http://stackoverflow.com/questions/2826380/concurrentmodificationexception-hashmap-in-java. — Sunil Rajashekar, Aug 15 '15 at 01:27
add try{}catch{} block below for loop and above if condition. Have empty catch block to ignore the exception. If you want to move to other collection framework, use ConcurrentHashMap — Ravindra babu, Aug 15 '15 at 01:29
Thank you guys, for the ConcurrentHashMap ideea,did not know these even existed. Your answer is the winner xD. — Tudorut Robert, Aug 15 '15 at 07:47

score 0 · Answer 1 · answered Aug 15 '15 at 01:38

You can use iterator for removing entities that you detect for removing.

new BukkitRunnable() {
    public void run() {
        for(Iterator<Entity> it = CheckAliveEntities.keySet().iterator(); it.hasNext();) {
            Entity e = it.next();
            if ( !e.isValid() && !(e instanceof Player) ) {
                        System.out.println("DA");
                        x.removeHologram(e); // needs refactoring
                        it.remove();
                        y.setEntityRespawn(e); // needs refactoring
                        break;
                    }
            }
        }
    }       
}.runTaskTimer(this, 5, 5);

I'm not sure whether it's removeHologram() or setEntityRespawn() is removing the entity. In any case, I would refactor the logic so that you can remove the entity in the for loop itself. Although you do have option to pass iterator itself to these methods, and call it.remove() in there.

If you have multiple BukkitRunnable threads running, and they all have access to same HashMap, then it's advisable to use ConcurrentHashMap implementation for CheckAliveEntities. Please see http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ConcurrentHashMap.html

HashMap Concurrent Modification

1 Answers1