html form not working in firefox

Question

I have just started learning PHP and I cant seem to to work like this is not going to welcome.php please help? Thankyou for your help as I have litterally put my head into this :(

$user=$_POST['user'];
$pass=$_POST['pass'];


$que ="SELECT * FROM users WHERE username='$user' and password='$pass'";
$res=mysql_query($que);

    $c=mysql_num_rows($res);

    if($c==1){
    $_SESSION['user'] = $user; 
    header("location: welcome.php");
    }
    else {
    header("location: empty.php");
    }
    ?>




        <form name="myform" method="POST" action="login.php">


         <input name="username" type="text" id="username">

         <input name="pass" input type="password" id="pass">

         <input type="submit" name="Submit" value="Login">

        </form>

your input `name` is `username`... not `user`.. just change it! `$_POST['username'];` or change the `name='user'`. and I think you need to wrap it in `if(isset()){}`. — Sam Teng Wong, Aug 22 '15 at 12:42
another beginner learning deprecated code. PLEASE don't start off by using `mysql_` connections. Use `mysqli_` or `PDO`. It's easier to learn than unlearn. — nomistic, Aug 22 '15 at 13:02

UnderPhp · Answer 1 · 2015-08-22T13:13:55.463

Try this please:

      <?php
    session_start(); // You need this if you use a session    
        $user = mysql_escape_string($_POST['user']); // Defend from SQL Injection
            $pass = mysql_escape_string($_POST['pass']);

            if(isset($_POST['Submit']))
{
            $que = "SELECT * FROM users WHERE username='$user' and password='$pass';";
            $res = mysql_query($que);

                $c = mysql_num_rows($res);

                if($c==1){ // if you want use a session you need add session_start();
                $_SESSION['user'] = $user; 
                header("location: welcome.php");
                }
                else {
                header("location: empty.php");
                }
}
                ?>




                    <form name="myform" method="POST" action="login.php">


                     <input name="username" type="text" id="username">

                     <input name="pass" type="password" id="pass">

                     <input type="submit" name="Submit" value="Login">

                    </form>

@UnderPhp It would be better to explain your answer rather than "Try this" +1 for the efforts put on comments ;) — DirtyBit, Aug 22 '15 at 13:28

score 0 · Accepted Answer · answered Aug 22 '15 at 12:55

If you have properly used session_start(); It has already been mentioned where you have messed up, I will however post it for you so you can copy/paste and see it for yourself :) Furthermore, Beware of SQL Injection/XSS Study PDO/msqli

    <?php 
        session_start();
if(isset($_POST['Submit']){
        $user=$_POST['user'];
        $pass=$_POST['pass'];


        $que ="SELECT * FROM users WHERE username='$user' and password='$pass'";
        $res=mysql_query($que);

            $c=mysql_num_rows($res);

            if($c==1){
            $_SESSION['user'] = $user; 
            header("location: welcome.php");
            }
            else {
            header("location: empty.php");
            }

    }
    ?>

            <form name="myform" method="POST" action="login.php">


             <input name="user" type="text">

             <input name="pass" input type="password">

             <input type="submit" name="Submit" value="Login">

            </form>

SQL injection http://stackoverflow.com/questions/60174/how-can-i-prevent-sql-injection-in-php?rq=1 — Stanimir Dimitrov, Aug 22 '15 at 13:09
Please mark my answer if it worked :) and look here for more study: http://stackoverflow.com/questions/60174/how-can-i-prevent-sql-injection-in-php — DirtyBit, Aug 22 '15 at 13:09

html form not working in firefox

2 Answers2