jQuery .click function is not working?

Question

I have a javaScript file in which i am trying to bind a function named change by using jQuery i tried this code but it is not working?

 script.js

 for(var i=1; i<suggestionList.length; i++)
            {
                $list.append("<li>" + suggestionList[i] + "</li>");
                // attach handler for click on the suggestions
                $list.find("li").eq(i).click(function() {
                    change(suggestionList[0], suggestionList[i]);
                });
            }


    function change(changeto,changewith)
        {
            var replaceto=document.getElementById(changeto).innerHTML;
            var replacewith=changewith;
            var text1=document.getElementById("para").innerHTML;
            var afterRe=text1.replace(replaceto,replacewith);
            document.getElementById("para").innerHTML=afterRe;
        }

please help me why my code is not working?

can you set a fiddle ?? – Manoj Dhiman Aug 24 '15 at 10:38 — Manoj Dhiman, Aug 24 '15 at 10:38
can you send me the links of which u are talking about – kritika goyal Aug 24 '15 at 10:39 — kritika goyal, Aug 24 '15 at 10:39
check my answer if it solve your issue. – Manoj Dhiman Aug 24 '15 at 10:41 — Manoj Dhiman, Aug 24 '15 at 10:41

Manoj Dhiman · Answer 1 · 2015-08-24T11:34:10.457

0

you can't use i inside the for-loop for click event. I have set a demo jsfiddle here .check If it helps

for(var i=1; i<suggestionList.length; i++)
{
    $list.append("<li>" + suggestionList[i] + "</li>");
     // attach handler for click on the suggestions

}

$list.find("li").click(function() {
    changewith=$(this).html();
    change(suggestionList[0], changewith);
});

edited Aug 24 '15 at 11:34

answered Aug 24 '15 at 10:39

Manoj Dhiman

5,096
6
29
68

http://jsfiddle.net/ set your code here . – Manoj Dhiman Aug 24 '15 at 10:44
actually some server connectivity is there so fiddle can not help – kritika goyal Aug 24 '15 at 10:48
check your console is there any error?? – Manoj Dhiman Aug 24 '15 at 10:51
i checked it there is no error even i debugged the code – kritika goyal Aug 24 '15 at 10:53
can u tell another way of doing this if it isnot working? – kritika goyal Aug 24 '15 at 10:54
what is the purpose of this ?? – Manoj Dhiman Aug 24 '15 at 11:02
i m making an spellchecker where i have a list of words as suggestions n i want if i click on one of the suggestion it will replace with the wrong word – kritika goyal Aug 24 '15 at 11:05
that's what i am trying to do – kritika goyal Aug 24 '15 at 11:05
are you getting me? – kritika goyal Aug 24 '15 at 11:06
may be now looking on the above code u will get it – kritika goyal Aug 24 '15 at 11:06
comment your function where you are calling . and alert there . i think it is not getting the selection .` $list.find("li").eq(i).click(function() { change(suggestionList[0], suggestionList[i]); });` – Manoj Dhiman Aug 24 '15 at 11:07
is there any link available?? – Manoj Dhiman Aug 24 '15 at 11:08
hey what is this li? – kritika goyal Aug 24 '15 at 11:15
ok sorry wrong question – kritika goyal Aug 24 '15 at 11:15
can you show the link ?? – Manoj Dhiman Aug 24 '15 at 11:19
no i cant but i can share my code – kritika goyal Aug 24 '15 at 11:23
check the updated code . and also the link you need to change in function . – Manoj Dhiman Aug 24 '15 at 11:34
http://jsfiddle.net/gwph7776/1/ updated – Manoj Dhiman Aug 24 '15 at 11:38
let me now if it worked. – Manoj Dhiman Aug 24 '15 at 11:42
http://jsfiddle.net/gwph7776/3/ this will work – Manoj Dhiman Aug 24 '15 at 11:44

jQuery .click function is not working?

1 Answers1